From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B5BA1624E1 for ; Thu, 22 May 2025 17:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747933422; cv=none; b=s6gOVG5sNSonXsJMftPicGnLtG3dJ0LsyaE/xyXoW+f8H1b9qutlB1W04+rA1/6otlYw/C2XE6KNq1PTluX1oBRCbYMNJETluQOkRugasySO4ztZw3d156cyrpahIn/Xoo4sFYCXXXObbMOyfVBRHI0PHOylV3Zc9kvq5gWmyT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747933422; c=relaxed/simple; bh=inwYJxmGvsOLcPv8MEex1zXPiW0tG9fJW3dR20fuc7o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ohzwGqPyhJr3RaShi5gH8rXqaNCRZRrNxzjTtqFaIe9w/gcojH4+UWSfCfFK4A34NQxvD9qBAfTeR2EMJKkzcOE2NjJfCmaOigV7E+FRRwszZU1QkRQ1GyBxDWK6hfxLqb6BMJ0tBrd9XEZqX5sURHmSjUUs3fxC+vR3GhAKVDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dpVWm3DD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dpVWm3DD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89924C4CEE4; Thu, 22 May 2025 17:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747933421; bh=inwYJxmGvsOLcPv8MEex1zXPiW0tG9fJW3dR20fuc7o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dpVWm3DDgeeNbNSD4DG4r94EiQuyOe1WmyeWBoQthDZtWLnY7K5uwhPjnZV5ZxDdU Gnoxj0gEGlmN1mi1isA4eQMb3iCzG87U+PZYeAPPAMjm/x2uPp8UarAL5G5xADMTch iW1KrICUaUNs/JYhCo5zOwWnIC8+eWUGk74Ta6pkFTiCQQqMUTwftjjQWolnV/zFSi J/F4JMVhXlC9PJUI1Is2TO7OiL8qixUxUi462YqluVXSXMoFlh6RzSDN5+Q5qTjSGJ fmkReYBZo53XKwvE16wYvA7riYtpcH+zjBuN9u5Hveqh4m/H0y+u30Nt7VExn3Reo7 AQSIM5R3LneSg== Message-ID: Date: Thu, 22 May 2025 13:03:40 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/5] guestfs: Replace scripts/destroy_guestfs.sh with an Ansible playbook To: Luis Chamberlain Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250522133137.989457-1-cel@kernel.org> <20250522133137.989457-2-cel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/25 1:02 PM, Luis Chamberlain wrote: > On Thu, May 22, 2025 at 09:31:33AM -0400, cel@kernel.org wrote: >> From: Chuck Lever >> >> Start to make use of the Ansible libvirt module to handle libvirt >> guest configuration, and replace the open-coded loop over the >> content of guestfs/kdevops_nodes.yml. >> >> Signed-off-by: Chuck Lever >> +- name: Remove per-node configuration files >> + ansible.builtin.file: >> + path: "{{ item }}" >> + state: absent >> + loop: >> + - "{{ guestfs_path }}/{{ inventory_hostname }}" >> + - "{{ kdevops_storage_pool_path }}/guestfs/{{ inventory_hostname }}" > > Does this remove a directory? If so then: > > Reviewed-by: Luis Chamberlain > > Luis I think it does remove directories: guestfs/ is empty after these steps complete. -- Chuck Lever