Re: [PATCH 3/9] base_image: fix template dest fields in custom-image task

[Chuck Lever <chuck.lever@oracle.com>]

On 8/20/25 8:51 AM, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> The Ansible built-in template was using the wrong destiny module

s/destiny/destination

As I mentioned in the cover letter for the guestfs playbook series,
the "custom image" piece of that series was entirely untested, and the
category of fixes you've done in this series demonstrate that clearly.
Thank you for taking care of these!

For the series,

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> parameter name. Fix the typo.
> 
> https://docs.ansible.com/ansible/latest/collections/ansible/builtin/template_module.html#parameter-dest
> 
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> ---
>  playbooks/roles/base_image/tasks/custom-image.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/playbooks/roles/base_image/tasks/custom-image.yml b/playbooks/roles/base_image/tasks/custom-image.yml
> index ede44bd7..609dc515 100644
> --- a/playbooks/roles/base_image/tasks/custom-image.yml
> +++ b/playbooks/roles/base_image/tasks/custom-image.yml
> @@ -102,7 +102,7 @@
>  - name: Build the custom source
>    ansible.builtin.template:
>      src: "{{ role_path }}/templates/custom-source.j2"
> -    dst: "{{ custom_source }}"
> +    dest: "{{ custom_source }}"
>      mode: "u=rw,g=r,o=r"
>    when:
>      - not result.stat.exists
> @@ -118,7 +118,7 @@
>  - name: Build the custom index
>    ansible.builtin.template:
>      src: "{{ role_path }}/templates/custom-index.j2"
> -    dst: "{{ custom_index }}"
> +    dest: "{{ custom_index }}"
>      mode: "u=rw,g=r,o=r"
>    when:
>      - not result.stat.exists
> 


-- 
Chuck Lever