Re: [PATCH v2 08/10] Makefile: use inventory from ansible.cfg

[Chuck Lever <chuck.lever@oracle.com>]

On 5/2/25 9:47 AM, Daniel Gomez wrote:
> On Fri, May 02, 2025 at 02:13:25PM +0100, Daniel Gomez wrote:
>> diff --git a/workflows/linux/Makefile b/workflows/linux/Makefile
>> index 4d208e3e2de3d40e87df1e4d06a46723d05fb4da..199161fa29a503cec9593182d849422e73158597 100644
>> --- a/workflows/linux/Makefile
>> +++ b/workflows/linux/Makefile
>> @@ -75,6 +75,7 @@ linux-help-menu:
>>  		echo "linux-mount        - Mounts 9p path on targets" ;\
>>  	fi
>>  	@echo "linux-deploy       - Builds, installs, updates GRUB and reboots - useful for rapid development"
>> +	@echo "linux-build        - Builds kernel"
>>  	@echo "linux-install      - Only builds and installs Linux"
>>  	@echo "linux-uninstall    - Remove a kernel you can pass arguments for the version such as KVER=6.5.0-rc7-next-20230825"
>>  	@echo "linux-clone        - Only clones Linux"
>> @@ -91,51 +92,66 @@ LINUX_HELP_EXTRA :=
>>  PHONY += linux
>>  linux: $(KDEVOPS_NODES)
>>  	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
>> +		--limit 'all:!localhost' \
> 
> This is wrong. I just need to remove the inventory here and use playbook hosts:
> field.
> 
>>  		$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux-local.yml \
>>  		--extra-vars="$(BOOTLINUX_ARGS)"
>> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \
>> -		$(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
>> +	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
>> +		--limit 'all:!localhost' \
>> +		$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
>>  		--extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS)
> 
> This break HOSTS="host1 host2" variable somehow. Not sure where the issue is
> yet.
> 
> ==> [linux]
> + ansible-playbook -v -i playbooks/bootlinux.yml
> '--extra-vars=target_linux_git=/mirror/linux.git target_linux_tree=linux
> target_linux_ref=v6.15-rc4 target_linux_config=config-v6.15-rc4
> target_linux_kernelrelease= target_linux_localversion=
> target_linux_shallow_depth=1 bootlinux_9p=True bootlinux_9p_host_path='\''/
> media/tarkir/dagomez/src/linux-kdevops/kdevops/linux'\''
> bootlinux_9p_msize='\''131072'\'' bootlinux_9p_fsdev='\''kdevops_9p_fsdev'\''
> bootlinux_9p_security_model='\''none'\''
> bootlinux_9p_driver='\''virtio-9p-pci'\''
> bootlinux_9p_mount_tag='\''kdevops_9p_bootlinux'\'' bootlinux_cxl_test=' '-l
> "debian13-block-dev,debian13-nvme-dev"'
> [WARNING]: You are running the development version of Ansible. You should only
> run Ansible from "devel" if you are modifying the Ansible engine, or trying out
> features under development. This is a rapidly changing source of code and can
> become unstable at any point.
> usage: ansible-playbook [-h] [--version] [-v] [--private-key PRIVATE_KEY_FILE]
> [-u REMOTE_USER] [-c CONNECTION] [-T TIMEOUT] [--ssh-common-args
> SSH_COMMON_ARGS] [--sftp-extra-args SFTP_EXTRA_ARGS] [--scp-extra-args
> SCP_EXTRA_ARGS] [--ssh-extra-args SSH_EXTRA_ARGS] [-k |
>                         --connection-password-file CONNECTION_PASSWORD_FILE]
> [--force-handlers] [-b] [--become-method BECOME_METHOD] [--become-user
> BECOME_USER] [-K | --become-password-file BECOME_PASSWORD_FILE] [-t TAGS]
> [--skip-tags SKIP_TAGS] [-C] [-D] [-i INVENTORY] [--list-hosts] [-l SUBSET]
>                         [--flush-cache] [-e EXTRA_VARS] [--vault-id VAULT_IDS]
> [-J | --vault-password-file VAULT_PASSWORD_FILES] [-f FORKS] [-M MODULE_PATH]
> [--syntax-check] [--list-tasks] [--list-tags] [--step] [--start-at-task
> START_AT_TASK]
>                         playbook [playbook ...]
> ansible-playbook: error: the following arguments are required: playbook
> 
>  

I will apply 1/10 through 7/10 at least and exercise them a bit.


-- 
Chuck Lever