Re: [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml

[Daniel Gomez <da.gomez@kernel.org>]

On 19/05/2025 18.21, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> Clean-up: Address ansible-lint complaints:
> 
> fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.
> 
> name[casing]: All names should start with an uppercase letter.
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Task/Handler: oscheck distribution ospecific setup
> 
> fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.
> 
> name[missing]: All tasks should be named.
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Task/Handler: import_tasks suse/main.yml
> 
> fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.
> 
> name[missing]: All tasks should be named.
> playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Task/Handler: import_tasks redhat/main.yml


Can you reformat this to 72 char limit for commit message lines?


I'll soon send a patch to add Ansible linting to CI, so we can catch
any future attempts that might break existing fixes.


> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>


Reviewed-by: Daniel Gomez <da.gomez@samsung.com>

> ---
>   .../bootlinux/tasks/install-deps/main.yml     | 21 ++++++++++++-------
>   1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml
> index c4c16d20509c..51a207416ad3 100644
> --- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml
> +++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml
> @@ -1,8 +1,15 @@
>   ---
> -- name: oscheck distribution ospecific setup
> -  import_tasks: debian/main.yml
> -  when: ansible_facts['os_family']|lower == 'debian'
> -- import_tasks: suse/main.yml
> -  when: ansible_facts['os_family']|lower == 'suse'
> -- import_tasks: redhat/main.yml
> -  when: ansible_facts['os_family']|lower == 'redhat'
> +- name: Debian-specific setup
> +  ansible.builtin.import_tasks: debian/main.yml
> +  when:
> +    - ansible_os_family == "Debian"
> +
> +- name: SuSE-specific setup
> +  ansible.builtin.import_tasks: suse/main.yml
> +  when:
> +    - ansible_os_family == "Suse"
> +
> +- name: Red Hat-specific setup
> +  ansible.builtin.import_tasks: redhat/main.yml
> +  when:
> +    - ansible_os_family == "RedHat"