From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A242116FE for ; Tue, 20 May 2025 18:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765646; cv=none; b=mbAdnhIU8hTg62j9xOoM4OBUQ8M8nMhtYAfQ3b6yDbaJppgwwmpieorbZ3f2J2SBQMypqHRxsHKLexbo2xkkpvPA/xmKH9QQCiNMqPKJNA5nI+Eg/wjd7WwMNR4NOAP2NdvVgH7YjcRACPjwLUgv2R2bKwNssSYxiXE6cqRtrdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765646; c=relaxed/simple; bh=vWVZs2I40wKEe1ec2Thp9315JfzFwCqW+nmUfVhlbzE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QdchkZxsO7ZrJvMJQha5UAeNr1NQfMGVpnb+yzyuQNANjGoaKmNxFsqrlf/kktJXVTDId1CzGVYWd3PEge3NK/9qtRdcfFzcWtr4d0FZUd74MEXhz2oc9znoVKzW8u370yl2nT8lSOM5cr1PNOwPJ1ma6NO4mO6HaFSTl2zpFsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YNyW0eTF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YNyW0eTF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73DF7C4CEE9; Tue, 20 May 2025 18:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747765646; bh=vWVZs2I40wKEe1ec2Thp9315JfzFwCqW+nmUfVhlbzE=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=YNyW0eTFF+UvT/sS2aERFaHtmpOBJ7wwrv5VIiyJkE3QG96N84TWagpM0hvPSVmwH Ig/bBvwzRiZ8/6ujBlQXbuw72g0n2ciJe4paY+v2PT4mIloWcKDjPjkFmzC2MgdqS7 od2k/kld7VRtzc8WWRRi1pB5EMVsjmzm8RR485v4205DITr010J6Rrz+WOMMUDGF4F 8PpdFcICgR/6juByJ2cLjaNQp7G6ZJCOj2x/cx56VN6LJOjaytOpBDtGC1Nym+yFQE i1FEdUwBACwTi4pKZ19KbgUiEq37ZgpaOoPP+PjqyAElT+Fs0K63Tf1ZlAO7Q9o8ix l8k1lZ+kbsAxA== Message-ID: Date: Tue, 20 May 2025 20:27:23 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: da.gomez@kernel.org Subject: Re: [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml To: cel@kernel.org, kdevops@lists.linux.dev Cc: Chuck Lever References: <20250519162131.381359-1-cel@kernel.org> <20250519162131.381359-3-cel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250519162131.381359-3-cel@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/05/2025 18.21, cel@kernel.org wrote: > From: Chuck Lever > > Clean-up: Address ansible-lint complaints: > > fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). > playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. > > name[casing]: All names should start with an uppercase letter. > playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Task/Handler: oscheck distribution ospecific setup > > fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). > playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. > > name[missing]: All tasks should be named. > playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Task/Handler: import_tasks suse/main.yml > > fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). > playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. > > name[missing]: All tasks should be named. > playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Task/Handler: import_tasks redhat/main.yml Can you reformat this to 72 char limit for commit message lines? I'll soon send a patch to add Ansible linting to CI, so we can catch any future attempts that might break existing fixes. > > Signed-off-by: Chuck Lever Reviewed-by: Daniel Gomez > --- > .../bootlinux/tasks/install-deps/main.yml | 21 ++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml > index c4c16d20509c..51a207416ad3 100644 > --- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml > +++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml > @@ -1,8 +1,15 @@ > --- > -- name: oscheck distribution ospecific setup > - import_tasks: debian/main.yml > - when: ansible_facts['os_family']|lower == 'debian' > -- import_tasks: suse/main.yml > - when: ansible_facts['os_family']|lower == 'suse' > -- import_tasks: redhat/main.yml > - when: ansible_facts['os_family']|lower == 'redhat' > +- name: Debian-specific setup > + ansible.builtin.import_tasks: debian/main.yml > + when: > + - ansible_os_family == "Debian" > + > +- name: SuSE-specific setup > + ansible.builtin.import_tasks: suse/main.yml > + when: > + - ansible_os_family == "Suse" > + > +- name: Red Hat-specific setup > + ansible.builtin.import_tasks: redhat/main.yml > + when: > + - ansible_os_family == "RedHat"