public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: kdevops@lists.linux.dev
Subject: guestfs storage paths are confusing
Date: Tue, 8 Apr 2025 15:17:29 -0400	[thread overview]
Message-ID: <ea2c44c1-3172-4e86-98ba-48dfdc403808@oracle.com> (raw)

Hi -

When I run "make defconfig-xxx" and then "make", .extra_vars_auto.yaml
contains:

> kdevops_enable_guestfs: True
> storage_pool_path: "/var/lib/libvirt/images"
> guestfs_storage_dir: "{{ kdevops_storage_pool_path }}/kdevops/guestfs"
> guestfs_base_image_dir: "{{ guestfs_storage_dir }}/base_images"
> libvirt_storage_pool_path: "/var/lib/libvirt/images"
> kdevops_storage_pool_path: "{{ libvirt_storage_pool_path }}/kdevops"
> libvirt_extra_storage_drive_virtio: True


After templating, that makes guestfs_storage_dir:

   /var/lib/libvirt/images/kdevops/kdevops/guestfs

Which seems incorrect to me. Perhaps guestfs_storage_dir
should be defined as simply:

  guestfs_storage_dir: "{{ kdevops_storage_pool_path }}/guestfs" ??

Also, I'd still like to replace the "kdevops" string literal in the
kdevops_storage_pool_path variable with:

  {{ kdevops_storage_pool_user }}

So that multiple users on one system that run kdevops can't clobber each
other's virtual machines or block devices.

-- 
Chuck Lever


             reply	other threads:[~2025-04-08 19:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 19:17 Chuck Lever [this message]
2025-04-08 19:29 ` guestfs storage paths are confusing Luis Chamberlain
2025-04-09 14:55   ` Chuck Lever
2025-04-09 18:10     ` Luis Chamberlain
2025-04-09 18:36       ` Chuck Lever
2025-04-09 23:46         ` Luis Chamberlain
2025-04-10  4:58       ` Andreas Hindborg
2025-04-23  6:04         ` Luis Chamberlain
2025-04-23  8:22           ` Andreas Hindborg
2025-04-23 20:53             ` Luis Chamberlain
2025-04-25  7:30               ` Andreas Hindborg
2025-04-25 21:31                 ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea2c44c1-3172-4e86-98ba-48dfdc403808@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox