From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECED9303A0B for ; Wed, 15 Oct 2025 18:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760552477; cv=none; b=M4Cr6cHnnkwXOslbPehTtCx65SCb13qfFzIJoTMLRwX9ALasVgZqm4oPQyUBcPkiFzwQOkAuwd6Mfz0ziHH2pWqyO+zuOgh6O6XNYJ6BlFfATu1jO98/+e1+1tccULL4xIGid1zfT6w8ScSsdHTbv6yHxdi70rlExGRe34HTOls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760552477; c=relaxed/simple; bh=CA/3y6iwcpamotoD/loOjp847MkqjESc+59MfYohsWc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TIgBUuBtrTVsYZ4kqm5PuN2rRtW1pqV4LbU0lnTW5OoVbZui+EbCu4e/qNkkGQBRNm+vYZyf4DsmDtWg3531RTWuZgz6rZ/IgGAoxy/T1E9tAsHej5EEIrOY8bRxQSKCUDZgv3zm0II1piHTcTEBYhj/uWVVAhtKLM7Il6YFKzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HoTh35JK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HoTh35JK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 649EFC4AF54; Wed, 15 Oct 2025 18:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760552475; bh=CA/3y6iwcpamotoD/loOjp847MkqjESc+59MfYohsWc=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=HoTh35JKk11Qwk+oJVR9YLReEIi33Ky1tPWiFn55LXH0PL4lPHPbQoEzdp2y/GWZe UxIolVTjirBDiEH7FxScr/dUN3mGR0ItxTeGhO9M7PmntEEmVxuGnvfUZyPXcCOUFA /1t2BTfbbG0I2nqw1FyRePegGztL4xdlGl8xEZiNQw/CglXxD9srtIUEWb4EdClSpv Bq76/iCvK/MkgXqsgJNTBs911A091jy80EaIfZ74juar2IutYZSLHQzXC+jyGXXKyV FMz6q0V4pPrJxdWR1LNGYDtw5vmbo4I5Dy2uhOdr5xmXXkRBsGqGmOVwBWeBMdgxoo thAW3Hit506BA== Message-ID: Date: Wed, 15 Oct 2025 20:21:12 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH 0/2] Locales fixes To: Chuck Lever , Daniel Gomez , Luis Chamberlain Cc: kdevops@lists.linux.dev References: <20250929-locales-all-removal-v1-0-4177411d3e44@samsung.com> <176046492150.25480.9143422994519608848.b4-ty@samsung.com> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/10/2025 23.35, Chuck Lever wrote: > On 10/14/25 2:02 PM, Daniel Gomez wrote: >> >> On Mon, 29 Sep 2025 21:04:11 +0200, Daniel Gomez wrote: >>> This drops locales-all from devconfig playbook and make en-US.UTF tasks >>> distro agnostic. While at it, also fix guest image permissions when the >>> base image is not copied and ensure idempotency with permissions. >>> >>> Note, the locales-all was in the wrong location (before removing >>> unattended-install Debian package) provoking the apt concurrency issue >>> (logs below) and not needed for en_US-UTF locale configuration added in >>> commit 2514a694 ("guestfs: fix locale warnings in VM deployment"). >>> >>> [...] >> >> Applied, thanks! >> >> [1/2] devconfig: drop locales-all leftovers >> (no commit info) >> [2/2] base_image: ensure base image permissions are set >> (no commit info) >> >> Best regards, > > > Hi Daniel! > > I'm seeing this on Fedora 41 with guestfs: > > TASK [devconfig : Configure en_US.UTF-8 locale files] > ****************************************************************************************** > changed: [kdevops-nfsd] => (item={'path': '/etc/default/locale', 'line': > 'LANG=en_US.UTF-8'}) > changed: [kdevops-nfsd] => (item={'path': '/etc/default/locale', 'line': > 'LANGUAGE=en_US:en'}) > changed: [kdevops-nfsd] => (item={'path': '/etc/locale.gen', 'line': > 'en_US.UTF-8 UTF-8'}) > [started TASK: devconfig : Generate and update locales on kdevops-nfsd] > > TASK [devconfig : Generate and update locales] > ************************************************************************************************* > task path: > /home/cel/src/kdevops/buildbot-configs/playbooks/roles/devconfig/tasks/main.yml:93 > fatal: [kdevops-nfsd]: FAILED! => { > "changed": true, > "cmd": "locale-gen en_US.UTF-8\nupdate-locale LANG=en_US.UTF-8\n", > "delta": "0:00:00.003794", > "end": "2025-10-14 17:30:14.766094", > "rc": 127, > "start": "2025-10-14 17:30:14.762300" > } > > STDERR: > > /bin/sh: line 1: locale-gen: command not found > /bin/sh: line 2: update-locale: command not found > > > MSG: > > non-zero return code > > > Neither of those commands appears in the Fedora 41 package inventory. > > Sorry for the trouble. I guess restoring this hunk fixes the issue, can you give it a try and confirm? diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index 39d883b7..ba55928e 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -88,6 +88,8 @@ - { path: "/etc/default/locale", line: "LANG=en_US.UTF-8" } - { path: "/etc/default/locale", line: "LANGUAGE=en_US:en" } - { path: "/etc/locale.gen", line: "en_US.UTF-8 UTF-8" } + when: + - ansible_facts['os_family']|lower == 'debian' tags: firstconfig - name: Generate and update locales @@ -98,6 +100,8 @@ locale-gen en_US.UTF-8 update-locale LANG=en_US.UTF-8 changed_when: true + when: + - ansible_facts['os_family']|lower == 'debian' tags: firstconfig - name: Check if /mirror directory exists on localhost Note, I can't fully test this or the patch, as it appears to be broken (at least for me) when using a Debian host and a Fedora guest with kdevops/libguestfs: virt-builder fedora-41 --arch x86_64 -o /xfs1/libvirt/images/kdevops/guestfs/base_images/fedora-41.raw --size 20G --format raw --commands-from-file /tmp/ansible.8r5zc3so [ 3.7] Downloading: http://builder.libguestfs.org/fedora-41.xz ###################################################################################################################################################################################################### 100.0% [ 140.6] Planning how to build this image [ 140.6] Uncompressing [ 141.7] Resizing (using virt-resize) to expand the disk to 20.0G [ 171.5] Opening the new disk [ 181.7] Setting a random seed [ 181.7] Installing packages: sudo qemu-guest-agent python3 bash policycoreutils-python-utils [ 194.7] Uninstalling packages: dracut-config-rescue [ 195.0] Deleting: /boot/*rescue* [ 195.0] Deleting: /boot/loader/entries/*rescue* [ 195.0] Running: useradd -u 1012 -s /bin/bash -m kdevops [ 195.1] Appending line to /etc/sudoers.d/kdevops [ 195.1] Editing: /etc/default/grub [ 195.2] Running: /usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg [ 195.9] Installing packages: isc-dhcp-client ifupdown Updating and loading repositories: Fedora 41 - x86_64 100% | 221.4 KiB/s | 30.3 KiB | 00m00s Fedora 41 - x86_64 - Updates 100% | 289.6 KiB/s | 29.0 KiB | 00m00s Fedora 41 openh264 (From Cisco) - x86_ 100% | 3.2 KiB/s | 986.0 B | 00m00s Fedora 41 - x86_64 100% | 241.7 KiB/s | 480.5 KiB | 00m02s Fedora 41 - x86_64 - Updates 100% | 4.4 MiB/s | 11.5 MiB | 00m03s Fedora 41 openh264 (From Cisco) - x86_ 100% | 7.3 KiB/s | 5.8 KiB | 00m01s Repositories loaded. Package "sudo-1.9.15-5.p5.fc41.x86_64" is already installed. ... Complete! Generating grub configuration file ... Adding boot menu entry for UEFI Firmware Settings ... done Updating and loading repositories: Repositories loaded. Failed to resolve the transaction: No match for argument: isc-dhcp-client No match for argument: ifupdown You can try to add to command line: --skip-unavailable to skip unavailable packages virt-builder: error: dnf -y install 'isc-dhcp-client' 'ifupdown': command exited with an error If reporting bugs, run virt-builder with debugging enabled and include the complete output: virt-builder -v -x [...]