From: Daniel Gomez <da.gomez@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
Luis Chamberlain <mcgrof@kernel.org>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH 3/9] base_image: fix template dest fields in custom-image task
Date: Thu, 21 Aug 2025 10:22:45 +0200 [thread overview]
Message-ID: <f0921ece-c58b-4035-9b79-5a7d7c67b84c@kernel.org> (raw)
In-Reply-To: <e8090926-5300-4c04-9c8a-9019808558b9@oracle.com>
On 20/08/2025 06.29, Chuck Lever wrote:
> On 8/20/25 8:51 AM, Daniel Gomez wrote:
>> From: Daniel Gomez <da.gomez@samsung.com>
>>
>> The Ansible built-in template was using the wrong destiny module
>
> s/destiny/destination
Fixed.
>
> As I mentioned in the cover letter for the guestfs playbook series,
> the "custom image" piece of that series was entirely untested, and the
> category of fixes you've done in this series demonstrate that clearly.
> Thank you for taking care of these!
No problem. It seems that the custom path is the only way forward with Debian.
FYI, the CI machine was using a previously generated custom Debian image. There
was no space left on the CI server, so the cleanup forced me to jump into these
fixes. :)
BTW, I have some changes ready for Debian Forky for whenever new images are
released.
https://github.com/dkruces/kdevops/tree/debian-forky
>
> For the series,
>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Thanks! And pushed.
CI is working back again.
next prev parent reply other threads:[~2025-08-21 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 12:51 [PATCH 0/9] Fix guestfs custom-image path Daniel Gomez
2025-08-20 12:51 ` [PATCH 1/9] guestfs: base_image: fix custom-image include_tasks filename Daniel Gomez
2025-08-20 12:51 ` [PATCH 2/9] guestfs: export kconfig yaml missing variables Daniel Gomez
2025-08-20 12:51 ` [PATCH 3/9] base_image: fix template dest fields in custom-image task Daniel Gomez
2025-08-20 13:29 ` Chuck Lever
2025-08-21 8:22 ` Daniel Gomez [this message]
2025-08-20 12:51 ` [PATCH 4/9] base_image: custom-image: fix variable scoping conflicts Daniel Gomez
2025-08-20 12:51 ` [PATCH 5/9] guestfs: bringup: fix ssh key injection Daniel Gomez
2025-08-20 12:51 ` [PATCH 6/9] base_image: add become privileges for custom image setup Daniel Gomez
2025-08-20 12:51 ` [PATCH 7/9] guestfs: debian: ensure dhcpcd-base runtime dependency Daniel Gomez
2025-08-20 12:51 ` [PATCH 8/9] guestfs: add unified LIBVIRT_IMAGE_SIZE configuration Daniel Gomez
2025-08-20 12:51 ` [PATCH 9/9] guestfs: fix locale warnings in VM deployments Daniel Gomez
2025-08-21 7:26 ` [PATCH 0/9] Fix guestfs custom-image path Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0921ece-c58b-4035-9b79-5a7d7c67b84c@kernel.org \
--to=da.gomez@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=da.gomez@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox