From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB1D2F8BC0 for ; Thu, 21 Aug 2025 08:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755764568; cv=none; b=X/goe/hTWDTCtTeAjCw1llFSn4D5SH9wtabXQGsF3zqmUoq4ClP6V1q0i4OcaBt22gFFSSH+T/WtSkeVwYGPjccQXNBy2r1ovQzQWwM8qLN4FV0d3baBG3vr3Hd91BsthkZno6s6w1z2RU+uOXqeVB4WcmxJJOTNroNtWdWnmaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755764568; c=relaxed/simple; bh=NN9fy4g0c6J9X6I2bXsYNq+4mZ1qfW6t9dAxkJUg/gc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H4gus0VHN/L7oQWw+WPA60dU9s8FXiyavp/xSdQCIJdSkhq8lOHUjNIIfmok3SPDSE2bcjkWBGiU1w0p0bqyD1QB/cc0UQn4SSNUGgff6DlgNPuDCVo9EhWaiFGr8tnXh4EsX57md9hH+CDk249WNzcnyzBcTSiHaF6ySjBKNPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n/XCJzt/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n/XCJzt/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2794C4CEED; Thu, 21 Aug 2025 08:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755764567; bh=NN9fy4g0c6J9X6I2bXsYNq+4mZ1qfW6t9dAxkJUg/gc=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=n/XCJzt/CfLFQIQYO7CBU8ionk+YmNhHhXNvVGfpEnLQuxz6YX0eLG9ZaXPJSg6Tq 9YAb5oKC7B4i6gpv1mZfhCb2POsAEnq0ni91KS1ChOX34nmQ7te3VVnjGRIKs0C6Dp 7PAW74y5zeYUIza+hekIVq3vvw9gVJx9GFvGPJ0eWQUaHYr4CLxtry+uzqnGrxOflP sp0G0xi7uNyPV9LcOqDXtPvRS/BVhHo4wYVSe3NBTMpDhJHiRchoUMC+P1Zni8MJPJ qnT+2t/dxGwb0X72v1HZeK9VeCTx++kJl87UYA+i7x2bR34ihzQL+A5jVRVX5H1xER vCo2oMeVCcyRg== Message-ID: Date: Thu, 21 Aug 2025 10:22:45 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH 3/9] base_image: fix template dest fields in custom-image task To: Chuck Lever , Luis Chamberlain Cc: kdevops@lists.linux.dev, Daniel Gomez References: <20250820-guestfs-custom-image-fixes-v1-0-0fe1d69c3f33@samsung.com> <20250820-guestfs-custom-image-fixes-v1-3-0fe1d69c3f33@samsung.com> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/08/2025 06.29, Chuck Lever wrote: > On 8/20/25 8:51 AM, Daniel Gomez wrote: >> From: Daniel Gomez >> >> The Ansible built-in template was using the wrong destiny module > > s/destiny/destination Fixed. > > As I mentioned in the cover letter for the guestfs playbook series, > the "custom image" piece of that series was entirely untested, and the > category of fixes you've done in this series demonstrate that clearly. > Thank you for taking care of these! No problem. It seems that the custom path is the only way forward with Debian. FYI, the CI machine was using a previously generated custom Debian image. There was no space left on the CI server, so the cleanup forced me to jump into these fixes. :) BTW, I have some changes ready for Debian Forky for whenever new images are released. https://github.com/dkruces/kdevops/tree/debian-forky > > For the series, > > Reviewed-by: Chuck Lever Thanks! And pushed. CI is working back again.