From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE74F54918 for ; Sun, 28 Sep 2025 20:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759091409; cv=none; b=rEf8mPeKK8M0LAnlN6SUUvn8ZPDdilZ138MHRxEvekqgHPg1euxniHO+n6py9h3SR37DJEwUf0W1QTl3AeU03DIhdnCQXn2wiw0lZTw3PZTJaoEgXdPoNLHqTmJYBiTNmtJXrz8vuL7nm1JIFrvdVUHQjiRbfUXOuzIykYwNDdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759091409; c=relaxed/simple; bh=H7g7nOXN6JDMdIRrPS/0/pLGkjGb0VuKaIf7utKO1AQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ToBCI01fNBvr/rNdVAQqmiLsbWNrBHnSIlYwHBeZgMlTLq6GfbTeaGRwLONedPR0d98zl4rNAE/k/QDP2anfOesKaTFCZudfXUzpl4N7jLlUDAQz2fqeRNRacFQ0WkU7nKFZ42F4VomHr6VA+tdRbbSCsG+39mo6Vz4gyuvOYVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QzQwo9Uc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QzQwo9Uc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CF26C4CEF0; Sun, 28 Sep 2025 20:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759091408; bh=H7g7nOXN6JDMdIRrPS/0/pLGkjGb0VuKaIf7utKO1AQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QzQwo9UcFhHzzrJowAXh3XlEVncy/r9ctFbmIrlwfSX2HlWPhMnfJAB4rXkbGoQEV fCrNMtJ05NjptPKnPSWsl1tF6qnauxIFB9hDKGevk8RlnjxxwhzgH2AmBdbi+tBJ/x sTEkJosffVycZQXkUgKiylQJQnMAw012EsX/b5zNSWLNl3hwcUcb18UANhLsssPjpB qAnyEqqlud30qpb8PWQS94JZPNXC/daYxLiynVHKKAW2RFjP9jwCXdzfYA3wMMgG6f OTzjbQYvwpzxAh5WRlRYl2TVi8VTMP1SAYVh+nmN6Luh1L9/XrBjCmazVdt/pJu6PT jQgu5vlUdXBDg== Message-ID: Date: Sun, 28 Sep 2025 16:30:07 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file To: Daniel Gomez Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250928155341.901825-1-cel@kernel.org> <827d1b8e-d489-46a9-a49b-b3cf3a4fe097@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: <827d1b8e-d489-46a9-a49b-b3cf3a4fe097@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/28/25 12:53 PM, Daniel Gomez wrote: > I see! Thanks for reporting. Indeed my fix introduced this bug. I think > it'd be best to move KDEVOPS_NODES just after we assign the filename to it > (provision.Makefile -> guestfs.Makefile): > > diff --git a/Makefile b/Makefile > index 3653591d..26615b22 100644 > --- a/Makefile > +++ b/Makefile > @@ -144,16 +144,16 @@ endif > DEFAULT_DEPS += $(ANSIBLE_CFG_FILE) > DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE) > > -ifneq (,$(KDEVOPS_NODES)) > -DEFAULT_DEPS += $(KDEVOPS_NODES) > -endif > - > include scripts/provision.Makefile > include scripts/firstconfig.Makefile > include scripts/systemd-timesync.Makefile > include scripts/journal-server.Makefile > include scripts/update_etc_hosts.Makefile > > +ifneq (,$(KDEVOPS_NODES)) > +DEFAULT_DEPS += $(KDEVOPS_NODES) > +endif > + > KDEVOPS_BRING_UP_DEPS += $(KDEVOPS_BRING_UP_DEPS_EARLY) > KDEVOPS_BRING_UP_DEPS += $(KDEVOPS_PROVISIONED_DEVCONFIG) The above snippet seems to work without any new issues. > @@ -264,13 +264,13 @@ ifneq (,$(KDEVOPS_BRING_UP_DEPS)) > include scripts/bringup.Makefile > endif > > -$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_EXTRA_VARS) > +$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS) > $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ > --inventory localhost, \ > $(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \ > --extra-vars=@./extra_vars.yaml > > -$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) $(KDEVOPS_EXTRA_VARS) > +$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(ANSIBLE_INVENTORY_FILE) $(KDEVOPS_NODES_TEMPLATE) $(KDEVOPS_EXTRA_VARS) With this snippet, "make" emits a new complaint: TASK [ansible_cfg : Update ansible.cfg access modification time so make sees it updated] *************************************************************************************************************************************************** changed: [localhost] PLAY RECAP ********************************************************************************************************************************************************************************************************************************* localhost : ok=4 changed=2 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 make: Circular terraform/aws/nodes.tf <- /home/cel/src/kdevops/buildbot-configs/hosts dependency dropped. PLAY [Generate target node configuration] But otherwise, "make bringup" works as expected. -- Chuck Lever