kernel-hardening.lists.openwall.com archive mirror
 help / color / mirror / Atom feed
* [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated"
@ 2012-08-03 13:29 Richard Weinberger
  2012-08-03 13:34 ` [kernel-hardening] " Cyrill Gorcunov
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Richard Weinberger @ 2012-08-03 13:29 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Richard Weinberger, Randy Dunlap, Peter Zijlstra,
	Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable, #

get_robust_list has at least two valid use cases.
1. checkpoint/restore in userspace
2. post mortem analysis

Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
Cc: kernel-hardening@lists.openwall.com
Cc: spender@grsecurity.net
Cc: keescook@chromium.org
Cc: tglx@linutronix.de
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: xemul@parallels.com
Cc: <stable@vger.kernel.org> # 3.4.x
Cc: <stable@vger.kernel.org> # 3.5.x
Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 Documentation/feature-removal-schedule.txt |   10 ----------
 kernel/futex.c                             |    2 --
 kernel/futex_compat.c                      |    2 --
 3 Dateien geändert, 14 Zeilen entfernt(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index afaff31..a25482e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -506,16 +506,6 @@ Who:	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
 
 ----------------------------
 
-What:	get_robust_list syscall
-When:	2013
-Why:	There appear to be no production users of the get_robust_list syscall,
-	and it runs the risk of leaking address locations, allowing the bypass
-	of ASLR. It was only ever intended for debugging, so it should be
-	removed.
-Who:	Kees Cook <keescook@chromium.org>
-
-----------------------------
-
 What:	Removing the pn544 raw driver.
 When:	3.6
 Why:	With the introduction of the NFC HCI and SHDL kernel layers, pn544.c
diff --git a/kernel/futex.c b/kernel/futex.c
index e2b0fb9..d701be5 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index 83e368b..a9642d5 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 13:29 [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
@ 2012-08-03 13:34 ` Cyrill Gorcunov
  2012-08-03 14:04   ` richard -rw- weinberger
  2012-08-03 14:19 ` Eric W. Biederman
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Cyrill Gorcunov @ 2012-08-03 13:34 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Randy Dunlap, Peter Zijlstra, Eric W. Biederman, David Howells,
	Serge E. Hallyn, kernel-hardening, spender, keescook, tglx, xemul,
	stable, #3.4.x

On Fri, Aug 03, 2012 at 03:29:53PM +0200, Richard Weinberger wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis
> 
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
> Cc: kernel-hardening@lists.openwall.com
> Cc: spender@grsecurity.net
> Cc: keescook@chromium.org
> Cc: tglx@linutronix.de
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: xemul@parallels.com
> Cc: <stable@vger.kernel.org> # 3.4.x
> Cc: <stable@vger.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---

Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>

Thanks, Richard!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 13:34 ` [kernel-hardening] " Cyrill Gorcunov
@ 2012-08-03 14:04   ` richard -rw- weinberger
  0 siblings, 0 replies; 9+ messages in thread
From: richard -rw- weinberger @ 2012-08-03 14:04 UTC (permalink / raw)
  To: Cyrill Gorcunov
  Cc: Richard Weinberger, linux-kernel, linux-doc, dvhart,
	paul.gortmaker, jkosina, rob, Randy Dunlap, Peter Zijlstra,
	Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, xemul, stable

On Fri, Aug 3, 2012 at 3:34 PM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> On Fri, Aug 03, 2012 at 03:29:53PM +0200, Richard Weinberger wrote:
>> get_robust_list has at least two valid use cases.
>> 1. checkpoint/restore in userspace
>> 2. post mortem analysis
>>
>> Cc: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Darren Hart <dvhart@linux.intel.com>
>> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Cc: Jiri Kosina <jkosina@suse.cz>
>> Cc: Eric W. Biederman <ebiederm@xmission.com>
>> Cc: David Howells <dhowells@redhat.com>
>> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
>> Cc: kernel-hardening@lists.openwall.com
>> Cc: spender@grsecurity.net
>> Cc: keescook@chromium.org
>> Cc: tglx@linutronix.de
>> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
>> Cc: xemul@parallels.com
>> Cc: <stable@vger.kernel.org> # 3.4.x
>> Cc: <stable@vger.kernel.org> # 3.5.x
>> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>
> Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
>
> Thanks, Richard!

Looks like the patch itself did made into through vger.
Will resend later.

-- 
Thanks,
//richard

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 13:29 [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
  2012-08-03 13:34 ` [kernel-hardening] " Cyrill Gorcunov
@ 2012-08-03 14:19 ` Eric W. Biederman
  2012-08-03 17:17 ` Kees Cook
  2012-08-06 14:53 ` Peter Zijlstra
  3 siblings, 0 replies; 9+ messages in thread
From: Eric W. Biederman @ 2012-08-03 14:19 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Randy Dunlap, Peter Zijlstra, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable

Richard Weinberger <richard@nod.at> writes:

> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis

Looks good to me.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
> Cc: kernel-hardening@lists.openwall.com
> Cc: spender@grsecurity.net
> Cc: keescook@chromium.org
> Cc: tglx@linutronix.de
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: xemul@parallels.com
> Cc: <stable@vger.kernel.org> # 3.4.x
> Cc: <stable@vger.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  Documentation/feature-removal-schedule.txt |   10 ----------
>  kernel/futex.c                             |    2 --
>  kernel/futex_compat.c                      |    2 --
>  3 Dateien geändert, 14 Zeilen entfernt(-)
>
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index afaff31..a25482e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -506,16 +506,6 @@ Who:	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
>  
>  ----------------------------
>  
> -What:	get_robust_list syscall
> -When:	2013
> -Why:	There appear to be no production users of the get_robust_list syscall,
> -	and it runs the risk of leaking address locations, allowing the bypass
> -	of ASLR. It was only ever intended for debugging, so it should be
> -	removed.
> -Who:	Kees Cook <keescook@chromium.org>
> -
> -----------------------------
> -
>  What:	Removing the pn544 raw driver.
>  When:	3.6
>  Why:	With the introduction of the NFC HCI and SHDL kernel layers, pn544.c
> diff --git a/kernel/futex.c b/kernel/futex.c
> index e2b0fb9..d701be5 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> -	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> -
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;
> diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
> index 83e368b..a9642d5 100644
> --- a/kernel/futex_compat.c
> +++ b/kernel/futex_compat.c
> @@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> -	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> -
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated"
@ 2012-08-03 14:40 Richard Weinberger
  0 siblings, 0 replies; 9+ messages in thread
From: Richard Weinberger @ 2012-08-03 14:40 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Richard Weinberger, Randy Dunlap, Peter Zijlstra,
	Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable, #

get_robust_list has at least two valid use cases.
1. checkpoint/restore in userspace
2. post mortem analysis

Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
Cc: kernel-hardening@lists.openwall.com
Cc: spender@grsecurity.net
Cc: keescook@chromium.org
Cc: tglx@linutronix.de
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: xemul@parallels.com
Cc: <stable@vger.kernel.org> # 3.4.x
Cc: <stable@vger.kernel.org> # 3.5.x
Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 Documentation/feature-removal-schedule.txt |   10 ----------
 kernel/futex.c                             |    2 --
 kernel/futex_compat.c                      |    2 --
 3 Dateien geändert, 14 Zeilen entfernt(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index afaff31..a25482e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -506,16 +506,6 @@ Who:	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
 
 ----------------------------
 
-What:	get_robust_list syscall
-When:	2013
-Why:	There appear to be no production users of the get_robust_list syscall,
-	and it runs the risk of leaking address locations, allowing the bypass
-	of ASLR. It was only ever intended for debugging, so it should be
-	removed.
-Who:	Kees Cook <keescook@chromium.org>
-
-----------------------------
-
 What:	Removing the pn544 raw driver.
 When:	3.6
 Why:	With the introduction of the NFC HCI and SHDL kernel layers, pn544.c
diff --git a/kernel/futex.c b/kernel/futex.c
index e2b0fb9..d701be5 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index 83e368b..a9642d5 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 13:29 [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
  2012-08-03 13:34 ` [kernel-hardening] " Cyrill Gorcunov
  2012-08-03 14:19 ` Eric W. Biederman
@ 2012-08-03 17:17 ` Kees Cook
  2012-08-06 14:53 ` Peter Zijlstra
  3 siblings, 0 replies; 9+ messages in thread
From: Kees Cook @ 2012-08-03 17:17 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Randy Dunlap, Peter Zijlstra, Eric W. Biederman, David Howells,
	Serge E. Hallyn, kernel-hardening, spender, tglx, Cyrill Gorcunov,
	xemul, # 3.4.x

On Fri, Aug 3, 2012 at 6:29 AM, Richard Weinberger <richard@nod.at> wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis
>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
> Cc: kernel-hardening@lists.openwall.com
> Cc: spender@grsecurity.net
> Cc: keescook@chromium.org
> Cc: tglx@linutronix.de
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: xemul@parallels.com
> Cc: <stable@vger.kernel.org> # 3.4.x
> Cc: <stable@vger.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Chrome OS Security

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 17:16 [kernel-hardening] Re: [PATCH v2] futex: mark get_robust_list as deprecated Kees Cook
@ 2012-08-03 18:06 ` Richard Weinberger
  0 siblings, 0 replies; 9+ messages in thread
From: Richard Weinberger @ 2012-08-03 18:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Richard Weinberger, Randy Dunlap, Peter Zijlstra,
	Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable, #

get_robust_list has at least two valid use cases.
1. checkpoint/restore in userspace
2. post mortem analysis

Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
Cc: kernel-hardening@lists.openwall.com
Cc: spender@grsecurity.net
Cc: keescook@chromium.org
Cc: tglx@linutronix.de
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: xemul@parallels.com
Cc: <stable@vger.kernel.org> # 3.4.x
Cc: <stable@vger.kernel.org> # 3.5.x
Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Kees Cook <keescook@chromium.org>
---
 Documentation/feature-removal-schedule.txt |   10 ----------
 kernel/futex.c                             |    2 --
 kernel/futex_compat.c                      |    2 --
 3 files changed, 14 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index afaff31..a25482e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -506,16 +506,6 @@ Who:	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
 
 ----------------------------
 
-What:	get_robust_list syscall
-When:	2013
-Why:	There appear to be no production users of the get_robust_list syscall,
-	and it runs the risk of leaking address locations, allowing the bypass
-	of ASLR. It was only ever intended for debugging, so it should be
-	removed.
-Who:	Kees Cook <keescook@chromium.org>
-
-----------------------------
-
 What:	Removing the pn544 raw driver.
 When:	3.6
 Why:	With the introduction of the NFC HCI and SHDL kernel layers, pn544.c
diff --git a/kernel/futex.c b/kernel/futex.c
index e2b0fb9..d701be5 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index 83e368b..a9642d5 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
 	if (!futex_cmpxchg_enabled)
 		return -ENOSYS;
 
-	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
-
 	rcu_read_lock();
 
 	ret = -ESRCH;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-03 13:29 [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
                   ` (2 preceding siblings ...)
  2012-08-03 17:17 ` Kees Cook
@ 2012-08-06 14:53 ` Peter Zijlstra
  2012-08-06 14:57   ` Richard Weinberger
  3 siblings, 1 reply; 9+ messages in thread
From: Peter Zijlstra @ 2012-08-06 14:53 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Randy Dunlap, Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable, #, 3.4.x

On Fri, 2012-08-03 at 15:29 +0200, Richard Weinberger wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis 

Shouldn't this then also be added as a comment somewhere near the
implementation to avoid a repeat of this deprecate / undeprecate cycle?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [kernel-hardening] Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
  2012-08-06 14:53 ` Peter Zijlstra
@ 2012-08-06 14:57   ` Richard Weinberger
  0 siblings, 0 replies; 9+ messages in thread
From: Richard Weinberger @ 2012-08-06 14:57 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: linux-kernel, linux-doc, dvhart, paul.gortmaker, jkosina, rob,
	Randy Dunlap, Eric W. Biederman, David Howells, Serge E. Hallyn,
	kernel-hardening, spender, keescook, tglx, Cyrill Gorcunov, xemul,
	stable, #, 3.4.x

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Am 06.08.2012 16:53, schrieb Peter Zijlstra:
> On Fri, 2012-08-03 at 15:29 +0200, Richard Weinberger wrote:
>> get_robust_list has at least two valid use cases.
>> 1. checkpoint/restore in userspace
>> 2. post mortem analysis 
> 
> Shouldn't this then also be added as a comment somewhere near the
> implementation to avoid a repeat of this deprecate / undeprecate cycle?

Or someone submits a patch to glibc and the man-pages project to make this
system call official...

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-08-06 14:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-03 13:29 [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
2012-08-03 13:34 ` [kernel-hardening] " Cyrill Gorcunov
2012-08-03 14:04   ` richard -rw- weinberger
2012-08-03 14:19 ` Eric W. Biederman
2012-08-03 17:17 ` Kees Cook
2012-08-06 14:53 ` Peter Zijlstra
2012-08-06 14:57   ` Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2012-08-03 14:40 [kernel-hardening] " Richard Weinberger
2012-08-03 17:16 [kernel-hardening] Re: [PATCH v2] futex: mark get_robust_list as deprecated Kees Cook
2012-08-03 18:06 ` [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).