public inbox for kernel-hardening@lists.openwall.com
 help / color / mirror / Atom feed
From: william.c.roberts@intel.com
To: linux-kernel@vger.kernel.org, joe@perches.com, apw@canonical.com
Cc: keescook@chromium.org, kernel-hardening@lists.openwall.com,
	William Roberts <william.c.roberts@intel.com>
Subject: [kernel-hardening] [PATCH] checkpatch: add warning on %pk instead of %pK usage
Date: Fri, 10 Feb 2017 11:37:49 -0800	[thread overview]
Message-ID: <1486755469-21573-1-git-send-email-william.c.roberts@intel.com> (raw)

From: William Roberts <william.c.roberts@intel.com>

Sample output:
WARNING: %pk is close to %pK, did you mean %pK?.
\#20: FILE: drivers/char/applicom.c:230:
+			printk(KERN_INFO "Could not allocate IRQ %d for PCI Applicom device. %pk\n", dev->irq, pci_get_class);

Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 982c52c..f20f5c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6096,6 +6096,12 @@ sub process {
 			      "recursive locking is bad, do not use this ever.\n" . $herecurr);
 		}
 
+# check for bad %pK usage
+		if ($rawline =~ /\%pk/) {
+			WARN("FORMAT SPECIFIER",
+			      "%pk is close to %pK, did you mean %pK?.\n" . $herecurr);
+		}
+
 # check for lockdep_set_novalidate_class
 		if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
 		    $line =~ /__lockdep_no_validate__\s*\)/ ) {
-- 
2.7.4

             reply	other threads:[~2017-02-10 19:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 19:37 william.c.roberts [this message]
2017-02-10 20:12 ` [kernel-hardening] Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage Joe Perches
2017-02-10 22:14   ` [kernel-hardening] " Roberts, William C
2017-02-10 22:26     ` Roberts, William C
2017-02-10 22:49       ` [kernel-hardening] " Joe Perches
2017-02-10 22:59         ` Joe Perches
2017-02-10 23:31         ` [kernel-hardening] " Roberts, William C
2017-02-10 23:49           ` [kernel-hardening] " Joe Perches
2017-02-10 23:54         ` [kernel-hardening] " Roberts, William C
2017-02-11  0:01           ` [kernel-hardening] " Joe Perches
2017-02-11  1:32         ` [kernel-hardening] " Roberts, William C
2017-02-11  3:23           ` [kernel-hardening] " Joe Perches
2017-02-13 19:46             ` [kernel-hardening] " Roberts, William C
2017-02-13 20:14               ` [kernel-hardening] " Joe Perches
     [not found]               ` <1487016251.6214.6.camel@perches.com>
     [not found]                 ` <476DC76E7D1DF2438D32BFADF679FC562305F62F@ORSMSX103.amr.corp.intel.com>
2017-02-13 22:20                   ` Joe Perches
2017-02-15 23:49                     ` [kernel-hardening] " Roberts, William C
2017-02-16  0:19                       ` [kernel-hardening] " Joe Perches
2017-02-27 16:26                       ` [kernel-hardening] " Roberts, William C
2017-02-27 20:54                         ` [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p<foo> extensions Joe Perches
2017-02-27 21:18                           ` Kees Cook
2017-02-28 15:34                           ` [kernel-hardening] " Roberts, William C
2017-03-01  0:06                           ` [kernel-hardening] " Andrew Morton
2017-03-01  0:11                             ` Kees Cook
2017-03-01  1:14                               ` Joe Perches
2017-03-01  0:12                             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486755469-21573-1-git-send-email-william.c.roberts@intel.com \
    --to=william.c.roberts@intel.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox