From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <1488330874.25838.43.camel@perches.com> From: Joe Perches Date: Tue, 28 Feb 2017 17:14:34 -0800 In-Reply-To: References: <476DC76E7D1DF2438D32BFADF679FC562307BAE6@ORSMSX103.amr.corp.intel.com> <163a690510e636a23187c0dc9caa09ddac6d4cde.1488228427.git.joe@perches.com> <20170228160607.183a88bd491e97fa6a7ded9c@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions To: Kees Cook , Andrew Morton Cc: Andy Whitcroft , "Roberts, William C" , "kernel-hardening@lists.openwall.com" , LKML List-ID: On Tue, 2017-02-28 at 16:11 -0800, Kees Cook wrote: > On Tue, Feb 28, 2017 at 4:06 PM, Andrew Morton > wrote: > > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > > > > > %pK was at least once misused at %pk in an out-of-tree module. > > > This lead to some security concerns. Add the ability to track > > > single and multiple line statements for misuses of %p. > > > > Should we also do this? > > Ah yes, good idea. Maybe "...when adding/removing new conversion..." ? Deleting conversions seems unlikely.