From: "Tobin C. Harding" <me@tobin.cc>
To: kernel-hardening@lists.openwall.com
Cc: "Tobin C. Harding" <me@tobin.cc>,
Steven Rostedt <rostedt@goodmis.org>,
Tycho Andersen <tycho@tycho.ws>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org,
Network Development <netdev@vger.kernel.org>
Subject: [kernel-hardening] [PATCH 0/3] kallsyms: don't leak address
Date: Mon, 18 Dec 2017 10:53:29 +1100 [thread overview]
Message-ID: <1513554812-13014-1-git-send-email-me@tobin.cc> (raw)
This set plugs a kernel address leak that occurs if kallsyms symbol
look up fails. This set was prompted by a leaking address found using
scripts/leaking_addresses.pl on a PowerPC machine in the wild.
Patch set does not change behaviour when KALLSYMS is not defined
(suggested by Linus).
RFC has been in flight for 3 weeks with no negative response.
Patch 1 - return error code if symbol look up fails.
Patch 2 - print <no-symbol> to buffer if symbol look up returns an error.
Patch 3 - maintain current behaviour in ftrace.
Patch 3 (the ftrace stuff) is untested.
thanks,
Tobin.
Tobin C. Harding (3):
kallsyms: don't leak address when symbol not found
vsprintf: print <no-symbol> if symbol not found
trace: print address if symbol not found
include/linux/kernel.h | 2 ++
kernel/kallsyms.c | 6 ++++--
kernel/trace/trace.h | 24 ++++++++++++++++++++++++
kernel/trace/trace_events_hist.c | 6 +++---
lib/vsprintf.c | 18 +++++++++++++++---
5 files changed, 48 insertions(+), 8 deletions(-)
--
2.7.4
next reply other threads:[~2017-12-17 23:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 23:53 Tobin C. Harding [this message]
2017-12-17 23:53 ` [kernel-hardening] [PATCH 1/3] kallsyms: don't leak address when symbol not found Tobin C. Harding
2017-12-18 9:55 ` [kernel-hardening] " Felix Fietkau
2017-12-18 22:41 ` Tobin C. Harding
2017-12-18 23:43 ` Steven Rostedt
2017-12-19 0:24 ` Tobin C. Harding
2017-12-17 23:53 ` [kernel-hardening] [PATCH 2/3] vsprintf: print <no-symbol> if " Tobin C. Harding
2017-12-18 0:04 ` [kernel-hardening] " Joe Perches
2017-12-18 1:04 ` Tobin C. Harding
2017-12-17 23:53 ` [kernel-hardening] [PATCH 3/3] trace: print address " Tobin C. Harding
2017-12-18 16:49 ` [kernel-hardening] " Steven Rostedt
2017-12-18 21:16 ` Tobin C. Harding
2017-12-18 23:51 ` Steven Rostedt
2017-12-19 0:22 ` Tobin C. Harding
2017-12-19 3:00 ` Tobin C. Harding
2017-12-19 3:02 ` Tobin C. Harding
2017-12-19 3:37 ` Steven Rostedt
2017-12-19 4:20 ` Tobin C. Harding
2017-12-18 22:35 ` Tobin C. Harding
2017-12-19 23:19 ` kbuild test robot
2017-12-19 23:39 ` kbuild test robot
2017-12-18 5:31 ` [kernel-hardening] [PATCH 0/3] kallsyms: don't leak address Michael Ellerman
2017-12-18 6:00 ` Tobin C. Harding
2017-12-18 9:17 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513554812-13014-1-git-send-email-me@tobin.cc \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox