From: Vasiliy Kulikov <segoon@openwall.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
David Rientjes <rientjes@google.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Nick Piggin <npiggin@kernel.dk>,
Miklos Szeredi <mszeredi@suse.cz>,
Alexey Dobriyan <adobriyan@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>
Subject: [kernel-hardening] Re: [RFC v2 02/04] procfs: add hidepid modes as mount options
Date: Tue, 14 Jun 2011 18:24:29 +0400 [thread overview]
Message-ID: <20110614142429.GB3966@albatros> (raw)
In-Reply-To: <201106141554.50945.arnd@arndb.de>
On Tue, Jun 14, 2011 at 15:54 +0200, Arnd Bergmann wrote:
> On Sunday 12 June 2011, Vasiliy Kulikov wrote:
> > +static const match_table_t tokens = {
> > + {Opt_hidepid, "hidepid=%u"},
> > + {Opt_gid, "gid=%u"},
> > + {Opt_hidenet, "hidenet"},
> > + {Opt_nohidenet, "nohidenet"},
> > + {Opt_err, NULL},
> > +};
>
> I don't really have an opinion on your patch, but it seems that it does more than
> the description explains: The hidenet/nohidenet option is in the patch as well,
> although it doesn't have much of an effect.
Correct, it is just a matter of a patch division granularity. Alexey said
the patch should be divided into pid and net parts. I divided it into
(pid + all mount opts parsing) and (actual hidenet usage). As both pid
and net parts depend on options parsing, they are not fully independent,
and cannot be well splitted (or I just don't see how).
--
Vasiliy Kulikov
next prev parent reply other threads:[~2011-06-14 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 14:45 [kernel-hardening] [RFC v2 02/04] procfs: add hidepid modes as mount options Vasiliy Kulikov
2011-06-14 13:54 ` [kernel-hardening] " Arnd Bergmann
2011-06-14 14:24 ` Vasiliy Kulikov [this message]
2011-06-14 14:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614142429.GB3966@albatros \
--to=segoon@openwall.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=npiggin@kernel.dk \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox