From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com Sender: Vasiliy Kulikov Date: Sun, 3 Jul 2011 15:42:39 +0400 From: Vasiliy Kulikov Message-ID: <20110703114239.GA4074@albatros> References: <20110626194618.GA21740@elte.hu> <20110626202518.GA4915@albatros> <20110626220126.GA24004@elte.hu> <20110627083633.GA5846@albatros> <20110627104058.45e93c41@pyx> <20110627183829.GA16033@albatros> <20110701143757.GA22567@albatros> <20110701154947.133c30f5@lxorguk.ukuu.org.uk> <20110703100131.GA2472@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110703100131.GA2472@albatros> Subject: [kernel-hardening] Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk() To: Alan Cox Cc: Linus Torvalds , Ingo Molnar , Andrew Morton , James Morris , Namhyung Kim , Greg Kroah-Hartman , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org List-ID: On Sun, Jul 03, 2011 at 14:01 +0400, Vasiliy Kulikov wrote: > diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c > index fc2cdb6..b2a659b 100644 > --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c > +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c > @@ -38,7 +38,7 @@ static unsigned int dbg_level; > > static char version[] = > DRV_MODULE_DESC " " DRV_MODULE_NAME > - " v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n"; > + " v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")"; > > MODULE_AUTHOR("Chelsio Communications, Inc."); > MODULE_DESCRIPTION(DRV_MODULE_DESC); > @@ -1402,7 +1402,7 @@ static int __init cxgb3i_init_module(void) > { > int rc; > > - printk(KERN_INFO "%s", version); > + printk(KERN_INFO "%s\b", version); Surely this and init/main.c should have \n, sorry. -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments