From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Andreas Ziegler <andreas.ziegler@fau.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Jessica Yu <jeyu@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [kernel-hardening] Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings
Date: Mon, 28 Nov 2016 18:18:31 +0900 [thread overview]
Message-ID: <20161128091830.GB23034@linaro.org> (raw)
In-Reply-To: <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
> Hi Akashi,
>
> your patch "module: extend 'rodata=off' boot cmdline parameter to module
> mappings" showed up in linux-next today, and I noticed a small error in it.
>
> The first modified #ifdef is fine, the second one, however, has a spelling
> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
Thank you for pointing this out.
(I didn't notice it because DEBUG_RODATA is always on on arm64.)
Rusty, Jessica, should I submit v4 to correct it?
-Takahiro AKASHI
> I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which is essentialy diffing the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
>
> Best regards,
>
> Andreas
next parent reply other threads:[~2016-11-28 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
2016-11-28 9:18 ` AKASHI Takahiro [this message]
2016-11-28 19:50 ` [kernel-hardening] Re: module: extend 'rodata=off' boot cmdline parameter to module mappings Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128091830.GB23034@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=andreas.ziegler@fau.de \
--cc=jeyu@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).