* [kernel-hardening] Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings
[not found] <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
@ 2016-11-28 9:18 ` AKASHI Takahiro
2016-11-28 19:50 ` [kernel-hardening] " Jessica Yu
0 siblings, 1 reply; 2+ messages in thread
From: AKASHI Takahiro @ 2016-11-28 9:18 UTC (permalink / raw)
To: Andreas Ziegler, Rusty Russell, Jessica Yu
Cc: Kees Cook, kernel-hardening, linux-kernel
On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
> Hi Akashi,
>
> your patch "module: extend 'rodata=off' boot cmdline parameter to module
> mappings" showed up in linux-next today, and I noticed a small error in it.
>
> The first modified #ifdef is fine, the second one, however, has a spelling
> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
Thank you for pointing this out.
(I didn't notice it because DEBUG_RODATA is always on on arm64.)
Rusty, Jessica, should I submit v4 to correct it?
-Takahiro AKASHI
> I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which is essentialy diffing the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
>
> Best regards,
>
> Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
* [kernel-hardening] Re: module: extend 'rodata=off' boot cmdline parameter to module mappings
2016-11-28 9:18 ` [kernel-hardening] Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings AKASHI Takahiro
@ 2016-11-28 19:50 ` Jessica Yu
0 siblings, 0 replies; 2+ messages in thread
From: Jessica Yu @ 2016-11-28 19:50 UTC (permalink / raw)
To: AKASHI Takahiro, Andreas Ziegler, Rusty Russell, Kees Cook,
kernel-hardening, linux-kernel
+++ AKASHI Takahiro [28/11/16 18:18 +0900]:
>On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
>> Hi Akashi,
>>
>> your patch "module: extend 'rodata=off' boot cmdline parameter to module
>> mappings" showed up in linux-next today, and I noticed a small error in it.
>>
>> The first modified #ifdef is fine, the second one, however, has a spelling
>> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
>> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
>
>Thank you for pointing this out.
>(I didn't notice it because DEBUG_RODATA is always on on arm64.)
>
>Rusty, Jessica, should I submit v4 to correct it?
Andreas, Akashi -
The typo has been fixed with Arnd's patch:
http://lkml.kernel.org/r/20161128145931.3350661-1-arnd@arndb.de
Thanks for finding the issue!
Jessica
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-28 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
2016-11-28 9:18 ` [kernel-hardening] Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings AKASHI Takahiro
2016-11-28 19:50 ` [kernel-hardening] " Jessica Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).