From: Eric Biggers <ebiggers3@gmail.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@kernel.org>,
Kevin Hao <haokexin@gmail.com>, Oleg Nesterov <oleg@redhat.com>,
Wanpeng Li <wanpeng.li@hotmail.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Michael Halcrow <mhalcrow@google.com>,
Eric Biggers <ebiggers@google.com>
Subject: [kernel-hardening] [PATCH v4 0/3] x86/fpu: prevent leaking FPU registers via invalid FPU state
Date: Fri, 22 Sep 2017 10:41:53 -0700 [thread overview]
Message-ID: <20170922174156.16780-1-ebiggers3@gmail.com> (raw)
From: Eric Biggers <ebiggers@google.com>
This series fixes the bug found by syzkaller where the ptrace syscall
can be used to set invalid bits in a task's FPU state. I also found
that an equivalent bug was reachable using the sigreturn syscall, so the
first patch fixes the bug in both cases.
The other two patches start validating the other parts of the
xstate_header and make it so that invalid FPU states can no longer be
abused to leak the FPU registers of other processes.
Changes since v3:
- Rebase onto tip/master
Changes since v2:
- Use an exception handler to handle invalid FPU states
(suggested by Andy Lutomirski)
- Check the size of xstate_header.reserved at build time
(suggested by Dave Hansen)
Eric Biggers (3):
x86/fpu: don't let userspace set bogus xcomp_bv
x86/fpu: tighten validation of user-supplied xstate_header
x86/fpu: reinitialize FPU registers if restoring FPU state fails
arch/x86/include/asm/fpu/internal.h | 51 +++++++++++-------------------------
arch/x86/include/asm/fpu/xstate.h | 25 ++++++++++++++++++
arch/x86/kernel/fpu/regset.c | 17 +++++-------
arch/x86/kernel/fpu/signal.c | 18 ++++++++-----
arch/x86/kernel/fpu/xstate.c | 52 ++++++++++++++-----------------------
arch/x86/mm/extable.c | 24 +++++++++++++++++
6 files changed, 102 insertions(+), 85 deletions(-)
--
2.14.1.821.g8fa685d3b7-goog
next reply other threads:[~2017-09-22 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 17:41 Eric Biggers [this message]
2017-09-22 17:41 ` [kernel-hardening] [PATCH v4 1/3] x86/fpu: don't let userspace set bogus xcomp_bv Eric Biggers
2017-09-22 17:41 ` [kernel-hardening] [PATCH v4 2/3] x86/fpu: tighten validation of user-supplied xstate_header Eric Biggers
2017-09-22 17:41 ` [kernel-hardening] [PATCH v4 3/3] x86/fpu: reinitialize FPU registers if restoring FPU state fails Eric Biggers
2017-09-23 9:09 ` [kernel-hardening] Re: [PATCH v4 0/3] x86/fpu: prevent leaking FPU registers via invalid FPU state Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922174156.16780-1-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=ebiggers@google.com \
--cc=fenghua.yu@intel.com \
--cc=haokexin@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhalcrow@google.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=wanpeng.li@hotmail.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).