[kernel-hardening] Re: [PATCH 3/3] trace: print address if symbol not found

Tobin C. Harding
2017-12-19T04:20:09Z

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote:
> On Tue, 19 Dec 2017 14:00:11 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
>
> > I ran through these as outlined here for the new version (v4). This hits
> > the modified code but doesn't test symbol look up failure.
>
> stacktrace shouldn't post non kernel values, unless there's a frame
> pointer that isn't handled by kallsyms.
>
> As for the other two, we could probably force a failure, like:
>
> # echo 'hist:keys=hrtimer.sym' > \
> events/timer/hrtimer_start/trigger
> # cat events/timer/hrtimer_start/hist
>
> And then just add sym-offset too.
>
> > I also configured kernel with 'Perform a startup test on ftrace' for
> > good luck.
> >
> > Are you happy with this level of testing?
>
> Can you try the above.

Did both and in both cases we get the addresses as hoped :)

thanks,
Tobin.