Re: [PRE-REVIEW PATCH 14/16] tasklet: Remove the data argument from DECLARE_TASKLET() macros

Kees Cook
2019-09-30T22:51:04Z

On Sun, Sep 29, 2019 at 06:30:26PM +0200, Romain Perier wrote:
> Now that the .data field is removed from the tasklet_struct data
> structure and the DECLARE_TASKLET() macros body, we can change its API
> and remove the data argument. This commit updates the API of these
> macros by removing the data argument, it also update all the calls to
> these macros in a single shot.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> drivers/net/wan/farsync.c | 4 ++--
> drivers/staging/most/dim2/dim2.c | 2 +-
> drivers/staging/octeon/ethernet-tx.c | 2 +-
> drivers/tty/vt/keyboard.c | 2 +-
> drivers/usb/gadget/udc/snps_udc_core.c | 2 +-
> include/linux/interrupt.h | 4 ++--
> kernel/backtracetest.c | 2 +-
> kernel/debug/debug_core.c | 2 +-
> kernel/irq/resend.c | 2 +-
> net/atm/pppoatm.c | 2 +-
> sound/drivers/pcsp/pcsp_lib.c | 2 +-
> 11 files changed, 13 insertions(+), 13 deletions(-)

I'm glad there are so few users of the DECLARE_TASKLET() macros. :)

--
Kees Cook