From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F168FC432C0 for ; Fri, 22 Nov 2019 02:05:18 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 45C362067D for ; Fri, 22 Nov 2019 02:05:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e4DCSNwQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45C362067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17430-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 17663 invoked by uid 550); 22 Nov 2019 02:05:10 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 17629 invoked from network); 22 Nov 2019 02:05:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574388297; bh=gr/XBHOIomBO9YTccBT5tV/04vjrg4bPLRQHZ/upRIw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e4DCSNwQE+swxLteljdLwbIyHasX1yBVOhKXf1bGGYRpLbZNvN1cSP1sN9vgeuM// bhCcCzrsH39igs2o1xic/+pPJSVI6+NrUX4D+VV6D1DFVBQK1uqNnu8tJJ/apgowpH mE7eSmvoI7J/J558GFU7D9EWVv4tH0P4gH9sRMUk= Date: Thu, 21 Nov 2019 18:04:55 -0800 From: Eric Biggers To: Kees Cook Cc: Herbert Xu , =?iso-8859-1?Q?Jo=E3o?= Moreira , Ard Biesheuvel , Sami Tolvanen , Stephan Mueller , x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v6 1/8] crypto: x86/glue_helper: Regularize function prototypes Message-ID: <20191122020455.GA32523@sol.localdomain> References: <20191122010334.12081-1-keescook@chromium.org> <20191122010334.12081-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191122010334.12081-2-keescook@chromium.org> User-Agent: Mutt/1.12.2 (2019-09-21) On Thu, Nov 21, 2019 at 05:03:27PM -0800, Kees Cook wrote: > The crypto glue performed function prototype casting to make indirect > calls to assembly routines. Instead of performing casts at the call > sites (which trips Control Flow Integrity prototype checking), switch > each prototype to a common standard set of arguments which allows the > incremental removal of the existing macros. In order to keep pointer > math unchanged, internal casting between u128 pointers and u8 pointers > is added. > > Co-developed-by: Joćo Moreira > Signed-off-by: Kees Cook Co-developers need their own Signed-off-by. checkpatch.pl warns about this. - Eric