Re: [PATCH] sh: Stop printing the virtual memory layout

Kees Cook
2020-03-05T17:35:10Z

On Thu, Mar 05, 2020 at 10:46:58AM -0500, Arvind Sankar wrote:
> On Thu, Mar 05, 2020 at 04:41:05PM +0100, John Paul Adrian Glaubitz wrote:
> > On 3/5/20 4:38 PM, Joe Perches wrote:
> > >> Aww, why wasn't this made configurable? I found these memory map printouts
> > >> very useful for development.
> > >
> > > It could be changed from pr_info to pr_devel.
> > >
> > > A #define DEBUG would have to be added to emit it.
> >
> > Well, from the discussion it seems the decision to cut it out has already been
> > made, so I guess it's too late :(.
> >
> > Adrian
> >
> > --
> > .''`. John Paul Adrian Glaubitz
> > : :' : Debian Developer - glaubitz@debian.org
> > `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
> > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>
> Not really too late. I can do s/pr_info/pr_devel and resubmit.
>
> parisc for eg actually hides this in #if 0 rather than deleting the
> code.
>
> Kees, you fine with that?

I don't mind pr_devel(). ("#if 0" tends to lead to code-rot since it's
not subjected to syntax checking in case the names of things change.)
That said, it's really up to the arch maintainers.

--
Kees Cook