From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC42C54EEB for ; Tue, 24 Mar 2020 16:27:36 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id D1A1820788 for ; Tue, 24 Mar 2020 16:27:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GG3F8Z3D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1A1820788 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18181-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 9997 invoked by uid 550); 24 Mar 2020 16:27:29 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 9963 invoked from network); 24 Mar 2020 16:27:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585067236; bh=OvenVnHl0wduNQ7fLdM6lGKydIJWaN8/+ujyCQPdt68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GG3F8Z3DamEsezlqe5uUwSYKhHoSBCsOH1CvReBCyrJbdVmzoBSEaoPv/egxHTmqw u4L57AFmtNusYvewOS2xMoZfz66EPnA9ADi25j1dMOKR7so8/uyDD8dVvPn0VitWNE ItM72v4be6Kah5eRtkAqfyO66ZXiUl5G+bnYHRHM= Date: Tue, 24 Mar 2020 17:27:14 +0100 From: Greg KH To: Will Deacon Cc: linux-kernel@vger.kernel.org, Eric Dumazet , Jann Horn , Kees Cook , Maddie Stone , Marco Elver , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , kernel-team@android.com, kernel-hardening@lists.openwall.com Subject: Re: [RFC PATCH 01/21] list: Remove hlist_unhashed_lockless() Message-ID: <20200324162714.GB2518046@kroah.com> References: <20200324153643.15527-1-will@kernel.org> <20200324153643.15527-2-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324153643.15527-2-will@kernel.org> On Tue, Mar 24, 2020 at 03:36:23PM +0000, Will Deacon wrote: > Commit c54a2744497d ("list: Add hlist_unhashed_lockless()") added a > "lockless" variant of hlist_unhashed() that uses READ_ONCE() to access > the 'pprev' pointer of the 'hlist_node', the intention being that this > could be used by 'timer_pending()' to silence a KCSAN warning. As well > as forgetting to add the caller, the patch also sprinkles > {READ,WRITE}_ONCE() invocations over the standard (i.e. non-RCU) hlist > code, which is undesirable for a number of reasons: > > 1. It gives the misleading impression that the non-RCU hlist code is > in some way lock-free (despite the notable absence of any memory > barriers!) and silences KCSAN in such cases. > > 2. It unnecessarily penalises code generation for non-RCU hlist users > > 3. It makes it difficult to introduce list integrity checks because > of the possibility of concurrent callers. > > Retain the {READ,WRITE}_ONCE() invocations for the RCU hlist code, but > remove them from the non-RCU implementation. Remove the unused > 'hlist_unhashed_lockless()' function entirely and add the READ_ONCE() > to hlist_unhashed(), as we do already for hlist_empty() already. > > Cc: Eric Dumazet > Cc: Thomas Gleixner > Cc: Paul E. McKenney > Cc: Peter Zijlstra > Signed-off-by: Will Deacon > --- > include/linux/list.h | 33 ++++++++++----------------------- > 1 file changed, 10 insertions(+), 23 deletions(-) Reviewed-by: Greg Kroah-Hartman