From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0974C43331 for ; Tue, 24 Mar 2020 16:27:48 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 2344F20788 for ; Tue, 24 Mar 2020 16:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2344F20788 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18182-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 11733 invoked by uid 550); 24 Mar 2020 16:27:40 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 11699 invoked from network); 24 Mar 2020 16:27:39 -0000 Date: Tue, 24 Mar 2020 17:27:25 +0100 From: Greg KH To: Will Deacon Cc: linux-kernel@vger.kernel.org, Eric Dumazet , Jann Horn , Kees Cook , Maddie Stone , Marco Elver , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , kernel-team@android.com, kernel-hardening@lists.openwall.com Subject: Re: [RFC PATCH 02/21] list: Remove hlist_nulls_unhashed_lockless() Message-ID: <20200324162725.GC2518046@kroah.com> References: <20200324153643.15527-1-will@kernel.org> <20200324153643.15527-3-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324153643.15527-3-will@kernel.org> On Tue, Mar 24, 2020 at 03:36:24PM +0000, Will Deacon wrote: > Commit 02b99b38f3d9 ("rcu: Add a hlist_nulls_unhashed_lockless() function") > introduced the (as yet unused) hlist_nulls_unhashed_lockless() function > to avoid KCSAN reports when an RCU reader checks the 'hashed' status > of an 'hlist_nulls' concurrently undergoing modification. > > Remove the unused function and add a READ_ONCE() to hlist_nulls_unhashed(), > just like we do already for hlist_nulls_empty(). > > Cc: Paul E. McKenney > Cc: Peter Zijlstra > Signed-off-by: Will Deacon > --- > include/linux/list_nulls.h | 14 -------------- > 1 file changed, 14 deletions(-) Reviewed-by: Greg Kroah-Hartman