Re: [PATCH] gcc-common.h: 'params.h' has been dropped in GCC10

Kees Cook
2020-04-07T17:48:34Z

On Tue, Apr 07, 2020 at 07:22:55PM +0200, Frédéric Pierret wrote:
>
>
> On 2020-04-07 18:45, Kees Cook wrote:
> >
> > Hi! Thanks for the patch. I don't think this is a hack: it's the right
> > thing to do here, yes? GCC 10 includes this helper in gimple.h, so we
> > can ifdef it out in gcc-common.h.
> >
> > -Kees
> Hi Kees,
> Thank you very much for your comment. Would you like me to rephrase the commit including your comment too? "Hacky" mostly meaning humble modification from my point of view :)

Heh, no worries. I've just reproduced the failure you found with gcc 10,
and I've updated your commit log (and added -Wno-format-diag to the plug
builds). Here's what I've got in my tree now:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/gcc-plugins&id=dda632f1bc6da784baab8069e26547e3f4144dbe

Thanks for the patch!

-Kees

--
Kees Cook