From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3816FC433DF for ; Wed, 24 Jun 2020 07:11:43 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 89C35207DD for ; Wed, 24 Jun 2020 07:11:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jpmMG0PH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89C35207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-19084-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 1464 invoked by uid 550); 24 Jun 2020 07:11:36 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 1444 invoked from network); 24 Jun 2020 07:11:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IaIupdZDTPQkymgBfVG+0UDzO2HZVyEhIFNy78lMOE8=; b=jpmMG0PHfYi6EnAmdG5fjMx0DjviB4vfHp7oxw+UsZCuKGtKIGPQi/axyb5qwcz/QA ZauxRm4oA32Nn3tJIT1A1IknQybBPHIEaqBWXeV6EZXzFaFNG1rzC+DdW/cpf5FoYqst OuHNnTxKdxtEFHNy0ON5sPTSLlYJ7o0Bln868= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IaIupdZDTPQkymgBfVG+0UDzO2HZVyEhIFNy78lMOE8=; b=kvmgZTYs8YzKCzBcWvP9Eh8A0fl2MlRIVWMdZdM/29RgCi5D8Rezg4IK6R8hFJrAm0 zb3kLu9+ukDABB9krITDCbg4QY8Y9OnM6PB/v/6N4o3+CG6F8I75GL6EAWLHreSheu6c newu7BGMfPMUTfknNDmGKeE4L9VXkBnwHDl2SQkqe3CELmtU6dt3gFEZLoG5E4SLpzh8 5nzHr0VAlz/6+hryknCswL6GGWHIZ2zoQhRo9swY5Kurbhkt2U9HPOwxh7tWGHfxoNjM xzGqZypO5WuDN5m94WXHl6ZBJOExEeJ7LEHZIJMO5eTBaVzrXeGQOsOyKILjRw/WXlEy d3Rg== X-Gm-Message-State: AOAM532CnwDup07iqTnoQglWFG3YS407pYKVNkLaOfauKVPd5AAeMduQ uEtfOtfWFqZjo9EPUzYfAkEnlw== X-Google-Smtp-Source: ABdhPJzQdr21ClhxdwWwshImYU97Su78pVPktGGTYd8dh+NTMu+2Fty5hs3KNmkDqlNAUGQYwOx7jw== X-Received: by 2002:a63:ac53:: with SMTP id z19mr19935654pgn.181.1592982683374; Wed, 24 Jun 2020 00:11:23 -0700 (PDT) Date: Wed, 24 Jun 2020 00:11:21 -0700 From: Kees Cook To: Kristen Carlson Accardi Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, Jonathan Corbet , x86@kernel.org, "H. Peter Anvin" , arjan@linux.intel.com, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, Tony Luck , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 08/10] x86: Add support for function granular KASLR Message-ID: <202006240007.095694C@keescook> References: <20200623172327.5701-1-kristen@linux.intel.com> <20200623172327.5701-9-kristen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623172327.5701-9-kristen@linux.intel.com> On Tue, Jun 23, 2020 at 10:23:25AM -0700, Kristen Carlson Accardi wrote: > This commit contains the changes required to re-layout the kernel text > sections generated by -ffunction-sections shortly after decompression. > Documentation of the feature is also added. > [...] > Signed-off-by: Kristen Carlson Accardi > Reviewed-by: Tony Luck > Tested-by: Tony Luck This looks good! I wonder about some way (in the future) to share the sorting routines for kallsyms, exceptions, orc, etc. For now, though, I think this is fine. > [...] > + if (cmdline_find_option("fgkaslr", arg, sizeof(arg)) == 3 && > + !strncmp(arg, "off", 3)) { > + warn("FG_KASLR disabled on cmdline."); > + nofgkaslr = 1; > + } I was recently reminded by Randy Lunlap to document my new boot params, so I need to point out the same here. :) With a section added to Documentation/admin-guide/kernel-parameters.txt consider this: Reviewed-by: Kees Cook -- Kees Cook