Re: Clarification about the series to modernize the tasklet api

Oscar Carter
2020-07-18T12:22:19Z

On Mon, Jul 13, 2020 at 09:16:12AM -0700, Kees Cook wrote:
> On Mon, Jul 13, 2020 at 02:55:22PM +0530, Allen wrote:
> > Oscar,
> > >
> > > I'm working to modernize the tasklet api but I don't understand the reply
> > > to the patch 12/16 [1] of the patch series of Romain Perier [2].
> >
> > Am working on the same too. I did try reaching out to Romain but not luck.
> > Let's hope we are not duplicating efforts.

Don't worry. The work done by me for the moment has been to read all the Romain
patches.

> > > If this patch is combined with the first one, and the function prototypes
> > > are not changed accordingly and these functions don't use the from_tasklet()
> > > helper, all the users that use the DECLARE_TASKLET macro don't pass the
> > > correct argument to the .data field.
> > >
> > > #define DECLARE_TASKLET(name, func, data) \
> > > -struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), func, data }
> > > +struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), (TASKLET_FUNC_TYPE)func, (TASKLET_DATA_TYPE)&name }
> > >
> >
> > Ideally this above bit should have been part of the first patch.
>
> Right, the idea was to have a single patch that contained all the
> infrastructure changes to support the conversion patches.

Ok, thanks for the explanation.

> --
> Kees Cook

Thanks,
Oscar Carter