From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB370C6369E for ; Sat, 14 Nov 2020 00:49:45 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id C39302225E for ; Sat, 14 Nov 2020 00:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MqdPjOPO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C39302225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20401-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 23930 invoked by uid 550); 14 Nov 2020 00:49:37 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 23910 invoked from network); 14 Nov 2020 00:49:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605314964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Pgbto6s6aJWzu/I6GVSYjwAc7k98Nrj4vzE4Tm0+xE=; b=MqdPjOPOU08qh/5AeNZZD80BhRJhRRMv1j1N1TRgv+zccd2RWQg15A4kfTtoAXuG16pWoC GS4ZQRssuCpoIjI5VfC0xOSCpO4hSz7vobIeUInt1WZHY5cuzTjxombhZ5Nv+MZm8iFRZO aEk3kRBwGsaRSmoC7P+6zjlShb3U+QE= X-MC-Unique: cJKt-FEhN_unyUcxBk_KIQ-1 Date: Fri, 13 Nov 2020 18:49:11 -0600 From: Josh Poimboeuf To: Sami Tolvanen Cc: Peter Zijlstra , Jann Horn , the arch/x86 maintainers , Masahiro Yamada , Steven Rostedt , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , linux-kbuild , kernel list , linux-pci@vger.kernel.org Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <20201114004911.aip52eimk6c2uxd4@treble> References: <20201023173617.GA3021099@google.com> <20201110022924.tekltjo25wtrao7z@treble> <20201110174606.mp5m33lgqksks4mt@treble> <20201113195408.atbpjizijnhuinzy@treble> <20201113223412.inono2ekrs7ky7rm@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 On Fri, Nov 13, 2020 at 03:31:34PM -0800, Sami Tolvanen wrote: > > #else /* !CONFIG_STACK_VALIDATION */ > > @@ -123,6 +129,8 @@ struct unwind_hint { > > .macro UNWIND_HINT sp_reg:req sp_offset=0 type:req end=0 > > .endm > > #endif > > +.macro STACK_FRAME_NON_STANDARD func:req > > +.endm > > This macro needs to be before the #endif, so it's defined only for > assembly code. This breaks my arm64 builds even though x86 curiously > worked just fine. Yeah, I noticed that after syncing objtool.h with the tools copy. Fixed now. I've got fixes for some of the other warnings, but I'll queue them up and post when they're all ready. -- Josh