From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C17C433E0 for ; Wed, 24 Feb 2021 18:39:13 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 28AB864F03 for ; Wed, 24 Feb 2021 18:39:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28AB864F03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20820-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 6141 invoked by uid 550); 24 Feb 2021 18:39:04 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 6118 invoked from network); 24 Feb 2021 18:39:03 -0000 Date: Wed, 24 Feb 2021 19:38:28 +0100 From: Alexey Gladkov To: "Eric W. Biederman" Cc: kernel test robot , 0day robot , LKML , lkp@lists.01.org, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@intel.com, io-uring@vger.kernel.org, Kernel Hardening , Linux Containers , linux-mm@kvack.org, Andrew Morton , Christian Brauner , Jann Horn , Jens Axboe , Kees Cook , Linus Torvalds , Oleg Nesterov Subject: Re: d28296d248: stress-ng.sigsegv.ops_per_sec -82.7% regression Message-ID: <20210224183828.j6uut6sholeo2fzh@example.org> References: <20210224051845.GB6114@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.1 (raptor.unsafe.ru [5.9.43.93]); Wed, 24 Feb 2021 18:38:52 +0000 (UTC) On Wed, Feb 24, 2021 at 10:54:17AM -0600, Eric W. Biederman wrote: > kernel test robot writes: > > > Greeting, > > > > FYI, we noticed a -82.7% regression of stress-ng.sigsegv.ops_per_sec due to commit: > > > > > > commit: d28296d2484fa11e94dff65e93eb25802a443d47 ("[PATCH v7 5/7] Reimplement RLIMIT_SIGPENDING on top of ucounts") > > url: https://github.com/0day-ci/linux/commits/Alexey-Gladkov/Count-rlimits-in-each-user-namespace/20210222-175836 > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next > > > > in testcase: stress-ng > > on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz with 112G memory > > with following parameters: > > > > nr_threads: 100% > > disk: 1HDD > > testtime: 60s > > class: interrupt > > test: sigsegv > > cpufreq_governor: performance > > ucode: 0x42e > > > > > > In addition to that, the commit also has significant impact on the > > following tests: > > Thank you. Now we have a sense of where we need to test the performance > of these changes carefully. One of the reasons for this is that I rolled back the patch that changed the ucounts.count type to atomic_t. Now get_ucounts() is forced to use a spin_lock to increase the reference count. -- Rgrds, legion