Re: [PATCH v2 1/5] fs: Add support for an O_MAYEXEC flag on sys_open()

James Morris
2019-09-06T19:04:39Z

On Fri, 6 Sep 2019, Jeff Layton wrote:

> The fact that open and openat didn't vet unknown flags is really a bug.
>
> Too late to fix it now, of course, and as Aleksa points out, we've
> worked around that in the past. Now though, we have a new openat2
> syscall on the horizon. There's little need to continue these sorts of
> hacks.
>
> New open flags really have no place in the old syscalls, IMO.

Agree here. It's unfortunate but a reality and Linus will reject any such
changes which break existing userspace.

--
James Morris
<jmorris@namei.org>