From mboxrd@z Thu Jan 1 00:00:00 1970 References: <20170306220348.79702-1-thgarnie@google.com> <20170306220348.79702-2-thgarnie@google.com> <17ffcc5b-1c9a-51b6-272a-5eaecf1bc0c4@citrix.com> <5cf31779-45c5-d37f-86bc-d5afb3fb7ab6@oracle.com> <51c23e92-d1f0-427f-e069-c92fc4ed6226@oracle.com> From: Boris Ostrovsky Message-ID: <36579cc4-05e7-a448-767c-b9ad940362fc@oracle.com> Date: Thu, 9 Mar 2017 18:17:18 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: [kernel-hardening] Re: [Xen-devel] [PATCH v5 2/3] x86: Remap GDT tables in the Fixmap section To: Thomas Garnier Cc: Michal Hocko , Stanislaw Gruszka , kvm list , "linux-doc@vger.kernel.org" , Matt Fleming , Frederic Weisbecker , Josh Poimboeuf , Chris Wilson , "linux-mm@kvack.org" , Dave Hansen , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "linux-efi@vger.kernel.org" , Alexander Potapenko , Pavel Machek , "H . Peter Anvin" , "kernel-hardening@lists.openwall.com" , Jiri Olsa , zijun_hu , Prarit Bhargava , Andi Kleen , Len Brown , Jonathan Corbet , Michael Ellerman , Joerg Roedel , X86 ML , "Luis R . Rodriguez" , kasan-dev , Christian Borntraeger , Ingo Molnar , "xen-devel@lists.xenproject.org" , Borislav Petkov , Fenghua Yu , Jiri Kosina , Kees Cook , Arnd Bergmann , He Chen , Brian Gerst , Rusty Russell , Joonsoo Kim , lguest@lists.ozlabs.org, Andy Lutomirski , Andrey Ryabinin , Thomas Gleixner , Andrew Morton , Dmitry Vyukov , Juergen Gross , Lorenzo Stoakes , Paul Gortmaker , Andrew Cooper , "linux-pm@vger.kernel.org" , Ard Biesheuvel , "Rafael J . Wysocki" , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Peter Zijlstra , Paolo Bonzini , Vitaly Kuznetsov , Tim Chen List-ID: On 03/09/2017 05:31 PM, Thomas Garnier wrote: > On Thu, Mar 9, 2017 at 2:13 PM, Boris Ostrovsky > wrote: >>>> I don't have any experience with Xen so it would be great if virtme can test it. >>> I am pretty sure I tested this series at some point but I'll test it again. >>> >> >> Fails 32-bit build: >> >> >> /home/build/linux-boris/arch/x86/kvm/vmx.c: In function ‘segment_base’: >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: ‘host_gdt’ >> undeclared (first use in this function) >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: (Each undeclared >> identifier is reported only once >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: for each >> function it appears in.) >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to >> ‘int’ in declaration of ‘type name’ >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to >> ‘int’ in declaration of ‘type name’ >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: initialization >> from incompatible pointer type >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: unused >> variable ‘gdt’ >> >> >> -boris > It seems that I forgot to remove line 2054 on the rebase. My 32-bit > build comes clean but I assume it is not good enough compare to the > full version I build for 64-bit KVM testing. > > Remove just this line and it should build fine, I will fix this on the > next iteration. > > Thanks for testing, > So this, in fact, does break Xen in that the hypercall to set GDT fails. I will have lo look at this tomorrow but I definitely at least built with v3 of this series. And I don't see why I wouldn't have tested it once I built it. -boris