From: Laura Abbott <labbott@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Laura Abbott <labbott@fedoraproject.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <js1304@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Kees Cook <keescook@chromium.org>
Subject: [kernel-hardening] Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing
Date: Wed, 24 Feb 2016 10:09:16 -0800 [thread overview]
Message-ID: <56CDF1CC.6070903@redhat.com> (raw)
In-Reply-To: <56CDBCAB.9040001@redhat.com>
On 02/24/2016 06:22 AM, Paolo Bonzini wrote:
>
>
> On 15/02/2016 19:44, Laura Abbott wrote:
>> -static inline struct kmem_cache_node *free_debug_processing(
>> +static inline int free_debug_processing(
>> struct kmem_cache *s, struct page *page,
>> void *head, void *tail, int bulk_cnt,
>> unsigned long addr, unsigned long *flags) { return NULL; }
>
> I think this has a leftover flags argument.
>
> Paolo
>
Yes, I believe Andrew folded in a patch to the mm tree.
Thanks,
Laura
>> @@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
>> stat(s, FREE_SLOWPATH);
>>
>> if (kmem_cache_debug(s) &&
>> - !(n = free_debug_processing(s, page, head, tail, cnt,
>> - addr, &flags)))
>> + !free_debug_processing(s, page, head, tail, cnt, addr))
next prev parent reply other threads:[~2016-02-24 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 18:44 [kernel-hardening] [PATCHv2 0/4] Improve performance for SLAB_POISON Laura Abbott
2016-02-15 18:44 ` [kernel-hardening] [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Laura Abbott
2016-02-16 16:28 ` [kernel-hardening] " Christoph Lameter
2016-02-24 14:22 ` Paolo Bonzini
2016-02-24 18:09 ` Laura Abbott [this message]
2016-02-15 18:44 ` [kernel-hardening] [PATCHv2 2/4] slub: Fix/clean free_debug_processing return paths Laura Abbott
2016-02-16 16:30 ` [kernel-hardening] " Christoph Lameter
2016-02-15 18:44 ` [kernel-hardening] [PATCHv2 3/4] slub: Convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS Laura Abbott
2016-02-16 16:32 ` [kernel-hardening] " Christoph Lameter
2016-02-15 18:44 ` [kernel-hardening] [PATCHv2 4/4] slub: Relax CMPXCHG consistency restrictions Laura Abbott
2016-02-16 16:33 ` [kernel-hardening] " Christoph Lameter
2016-02-18 8:39 ` [kernel-hardening] Re: [PATCHv2 0/4] Improve performance for SLAB_POISON Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDF1CC.6070903@redhat.com \
--to=labbott@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).