From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCB4C433E0 for ; Wed, 8 Jul 2020 16:48:20 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 46AB220786 for ; Wed, 8 Jul 2020 16:48:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46AB220786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-19259-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 16095 invoked by uid 550); 8 Jul 2020 16:48:13 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 16072 invoked from network); 8 Jul 2020 16:48:12 -0000 IronPort-SDR: CS/kNqdRPLP+kQ7PaZi4TlZXXtGlLnVFKRsqObPvakSiuRwphc1ekpqAXSgZgT/71v3S7QzYT0 inPVOrU6II+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="136095910" X-IronPort-AV: E=Sophos;i="5.75,328,1589266800"; d="scan'208";a="136095910" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: 6MMsL8LobZj0NHElNGCZR9i1cX0Q5HUgnhNzrWmrFw9BeX368h7tv6pHkD8THPX8VxVTuCLjrj HtBYQMlWkiJw== X-IronPort-AV: E=Sophos;i="5.75,328,1589266800"; d="scan'208";a="280009112" Message-ID: <6cba1bdea35eb19492c5d2674f2a58aae8635155.camel@linux.intel.com> Subject: Re: [PATCH v3 09/10] kallsyms: Hide layout From: Kristen Carlson Accardi To: "Luck, Tony" , Kees Cook , Jann Horn Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arjan van de Ven , the arch/x86 maintainers , kernel list , Kernel Hardening , "Edgecombe, Rick P" Date: Wed, 08 Jul 2020 09:47:55 -0700 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F68AC3B@ORSMSX115.amr.corp.intel.com> References: <20200623172327.5701-1-kristen@linux.intel.com> <20200623172327.5701-10-kristen@linux.intel.com> <202006240815.45AAD55@keescook> <3908561D78D1C84285E8C5FCA982C28F7F68AC3B@ORSMSX115.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Tue, 2020-07-07 at 23:16 +0000, Luck, Tony wrote: > > Signed-off-by: Kristen Carlson Accardi > > Reviewed-by: Tony Luck > > Tested-by: Tony Luck > > I'll happily review and test again ... but since you've made > substantive > changes, you should drop these tags until I do. Will do - thanks! If nobody thinks this is a horrible direction, I'll clean up this patch and submit it with the rest as part of v4. > > FWIW I think random order is a good idea. Do you shuffle once? > Or every time somebody opens /proc/kallsyms? I am shuffling every single time that somebody opens /proc/kallsyms - this is because it's possible that somebody has loaded modules or bpf stuff and there may be new/different symbols to display.