From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: Jess Frazelle <me@jessfraz.com>, Rik van Riel <riel@redhat.com>,
open list <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init
Date: Sat, 11 Feb 2017 10:23:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702111016120.3734@nanos> (raw)
In-Reply-To: <CALAqxLWMP7MFNRPTU3Ar3m=D1hFdS=d7_tbhkyrEadUQrRe7qw@mail.gmail.com>
On Fri, 10 Feb 2017, John Stultz wrote:
> On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle <me@jessfraz.com> wrote:
> > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was
> > called only during init. Most of the caller functions were already annotated as
> > __init.
> > unregister_syscore_ops() was never called on these ops.
> > This protects the data structure from accidental corruption.
> >
> > Suggested-by: Kees Cook <keescook@chromium.org>
> > Signed-off-by: Jess Frazelle <me@jessfraz.com>
> > Acked-by: Rik van Riel <riel@redhat.com>
>
> Thanks for sending this out. Looks reasonable to me. I'll queue it for
> testing, targeting for 4.12.
NAK. See:
http://lkml.kernel.org/r/alpine.DEB.2.20.1702110948030.3734@nanos
Thanks,
tglx
next prev parent reply other threads:[~2017-02-11 9:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 1:37 [kernel-hardening] [PATCH v2 1/5] irq: set {msi_domain,syscore}_ops as __ro_after_init Jess Frazelle
2017-02-11 1:37 ` [kernel-hardening] [PATCH v2 2/5] time: mark syscore_ops " Jess Frazelle
2017-02-11 2:12 ` [kernel-hardening] " John Stultz
2017-02-11 9:23 ` Thomas Gleixner [this message]
2017-02-11 1:37 ` [kernel-hardening] [PATCH v2 3/5] pci: set msi_domain_ops " Jess Frazelle
2017-02-12 4:08 ` [kernel-hardening] " KY Srinivasan
2017-02-13 18:14 ` [kernel-hardening] " Keith Busch
2017-02-15 20:33 ` Bjorn Helgaas
2017-02-15 20:46 ` Kees Cook
2017-02-15 21:16 ` Thomas Gleixner
2017-02-16 14:35 ` Bjorn Helgaas
2017-02-16 14:38 ` Thomas Gleixner
2017-03-07 19:07 ` Bjorn Helgaas
2017-03-14 18:50 ` Jessica Frazelle
2017-03-14 19:24 ` Bjorn Helgaas
2017-02-11 1:37 ` [kernel-hardening] [PATCH v2 4/5] staging: " Jess Frazelle
2017-02-11 1:37 ` [kernel-hardening] [PATCH v2 5/5] x86: " Jess Frazelle
2017-02-11 9:14 ` [kernel-hardening] Re: [PATCH v2 1/5] irq: set {msi_domain,syscore}_ops " Thomas Gleixner
2017-02-11 9:23 ` Thomas Gleixner
2017-02-11 10:48 ` Jess Frazelle
2017-02-11 12:00 ` Thomas Gleixner
2017-02-11 12:17 ` Jessica Frazelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702111016120.3734@nanos \
--to=tglx@linutronix.de \
--cc=john.stultz@linaro.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@jessfraz.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox