public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_machine
Date: Sun, 04 Jun 2017 21:06:29 +0000	[thread overview]
Message-ID: <004250a0-d94b-7587-ae5d-524ba2911a16@users.sourceforge.net> (raw)
In-Reply-To: <9b9230f4-0f00-e019-75b4-571e29b52998@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 4 Jun 2017 21:12:36 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/arm/xen/p2m.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index 11e78432b663..f5f74ac637b9 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -148,7 +148,6 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
-	if (!p2m_entry) {
-		pr_warn("cannot allocate xen_p2m_entry\n");
+	if (!p2m_entry)
 		return false;
-	}
+
 	p2m_entry->pfn = pfn;
 	p2m_entry->nr_pages = nr_pages;
 	p2m_entry->mfn = mfn;
-- 
2.13.0


  parent reply	other threads:[~2017-06-04 21:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-04 21:04 [PATCH 0/3] ARM-XEN: Adjustments for __set_phys_to_machine_multi() SF Markus Elfring
2017-06-04 21:05 ` [PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine_multi() SF Markus Elfring
2017-06-05 17:16   ` Stefano Stabellini
2017-06-04 21:06 ` SF Markus Elfring [this message]
2017-06-05 17:17   ` [PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_mac Stefano Stabellini
2017-06-04 21:07 ` [PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment SF Markus Elfring
2017-06-05 17:18   ` Stefano Stabellini
2017-06-05 17:51 ` [PATCH 0/3] ARM-XEN: Adjustments for __set_phys_to_machine_multi() Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=004250a0-d94b-7587-ae5d-524ba2911a16@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox