From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 08 Dec 2016 15:43:13 +0000 Subject: Re: staging: comedi: usbdux: Split a condition check in usbdux_alloc_usb_buffers() Message-Id: <0063f739-69e0-2cce-be06-ff3685609d93@users.sourceforge.net> List-Id: References: <8cddc37d-4529-ada4-ac21-20e09e888d0d@users.sourceforge.net> <50c7beca-40ba-6d58-5e2d-568844382bfe@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Ian Abbott Cc: devel@driverdev.osuosl.org, Chris Cesare , Greg Kroah-Hartman , H Hartley Sweeten , LKML , kernel-janitors@vger.kernel.org > Actually, the original code worked fine, I got my doubts when some memory allocations are attempted without checking the desired success immediately. > and these changes will result in an Oops if the allocations fail. I'll e= xplain why, > since it isn't obvious without some knowledge of the clean-up strategy us= ed by comedi drivers: Thanks for your explanation. > =E2=80=A6, and all the other comedi drivers follow the same strategy of l= eaving clean-up > to their comedi 'detach' handler. Are there other source code parts worth for further considerations? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html