From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC7AC43460 for ; Wed, 7 Apr 2021 12:48:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A3EC6124B for ; Wed, 7 Apr 2021 12:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245717AbhDGMsi (ORCPT ); Wed, 7 Apr 2021 08:48:38 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15947 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232623AbhDGMsi (ORCPT ); Wed, 7 Apr 2021 08:48:38 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FFkfJ2VxtzyNjR; Wed, 7 Apr 2021 20:46:16 +0800 (CST) Received: from [10.174.178.48] (10.174.178.48) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 20:48:20 +0800 Subject: Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init() To: zhongbaisong , Christian Borntraeger , Janosch Frank , "Vasily Gorbik" , Heiko Carstens CC: , , References: <2f7d62a4-3e75-b2b4-951b-75ef8ef59d16@huawei.com> From: "weiyongjun (A)" Message-ID: <0210417d-23df-1fdc-2af8-b2664ed2c484@huawei.com> Date: Wed, 7 Apr 2021 20:48:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2f7d62a4-3e75-b2b4-951b-75ef8ef59d16@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.48] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Reported-by: Hulk Robot > Signed-off-by: Baisong Zhong > --- >  arch/s390/kernel/uv.c | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c > index cbfbeab57c3b..370f664580af 100644 > --- a/arch/s390/kernel/uv.c > +++ b/arch/s390/kernel/uv.c > @@ -460,8 +460,10 @@ static int __init uv_info_init(void) >          goto out_kobj; > >      uv_query_kset = kset_create_and_add("query", NULL, uv_kobj); > -    if (!uv_query_kset) > +    if (!uv_query_kset) { > +        rc = -ENOMEM; >          goto out_ind_files; > +    } Your patch is corrupted, please resend with correct format. > >      rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group); >      if (!rc) >