From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-s390@vger.kernel.org,
"Christian Bornträger" <borntraeger@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Peter Oberparleiter" <oberpar@linux.vnet.ibm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Sascha Silbe" <silbe@linux.vnet.ibm.com>,
"Vegard Nossum" <vegard.nossum@oracle.com>,
"Viktor Mihajlovski" <mihajlov@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/4] s390/sysinfo: Combine two function calls into one
Date: Sun, 07 May 2017 17:18:06 +0000 [thread overview]
Message-ID: <04517191-f1f5-19ca-d4bc-d3d5331b4556@users.sourceforge.net> (raw)
In-Reply-To: <fac68081-f0bb-2574-ba52-11ad78d792c3@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 May 2017 18:48:39 +0200
A bit of data was put into a sequence by two separate function calls
at four places. Print the same data by single function calls instead.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/sysinfo.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/arch/s390/kernel/sysinfo.c b/arch/s390/kernel/sysinfo.c
index e7061fcd047a..7f81d40c8f90 100644
--- a/arch/s390/kernel/sysinfo.c
+++ b/arch/s390/kernel/sysinfo.c
@@ -98,8 +98,7 @@ static void stsi_1_1_1(struct seq_file *m, struct sysinfo_1_1_1 *info)
seq_printf(m, "Model: %-16.16s", info->model_capacity);
if (info->model[0] != '\0')
seq_printf(m, " %-16.16s", info->model);
- seq_putc(m, '\n');
- seq_printf(m, "Sequence Code: %-16.16s\n", info->sequence);
+ seq_printf(m, "\nSequence Code: %-16.16s\n", info->sequence);
seq_printf(m, "Plant: %-4.4s\n", info->plant);
seq_printf(m, "Model Capacity: %-16.16s %08u\n",
info->model_capacity, info->model_cap_rating);
@@ -200,8 +199,7 @@ static void stsi_2_2_2(struct seq_file *m, struct sysinfo_2_2_2 *info)
if (stsi(info, 2, 2, 2))
return;
EBCASC(info->name, sizeof(info->name));
- seq_putc(m, '\n');
- seq_printf(m, "LPAR Number: %d\n", info->lpar_number);
+ seq_printf(m, "\nLPAR Number: %d\n", info->lpar_number);
seq_puts(m, "LPAR Characteristics: ");
if (info->characteristics & LPAR_CHAR_DEDICATED)
seq_puts(m, "Dedicated ");
@@ -209,8 +207,7 @@ static void stsi_2_2_2(struct seq_file *m, struct sysinfo_2_2_2 *info)
seq_puts(m, "Shared ");
if (info->characteristics & LPAR_CHAR_LIMITED)
seq_puts(m, "Limited ");
- seq_putc(m, '\n');
- seq_printf(m, "LPAR Name: %-8.8s\n", info->name);
+ seq_printf(m, "\nLPAR Name: %-8.8s\n", info->name);
seq_printf(m, "LPAR Adjustment: %d\n", info->caf);
seq_printf(m, "LPAR CPUs Total: %d\n", info->cpus_total);
seq_printf(m, "LPAR CPUs Configured: %d\n", info->cpus_configured);
@@ -256,8 +253,8 @@ static void stsi_3_2_2(struct seq_file *m, struct sysinfo_3_2_2 *info)
for (i = 0; i < info->count; i++) {
EBCASC(info->vm[i].name, sizeof(info->vm[i].name));
EBCASC(info->vm[i].cpi, sizeof(info->vm[i].cpi));
- seq_putc(m, '\n');
- seq_printf(m, "VM%02d Name: %-8.8s\n", i, info->vm[i].name);
+ seq_printf(m, "\nVM%02d Name: %-8.8s\n",
+ i, info->vm[i].name);
seq_printf(m, "VM%02d Control Program: %-16.16s\n", i, info->vm[i].cpi);
seq_printf(m, "VM%02d Adjustment: %d\n", i, info->vm[i].caf);
seq_printf(m, "VM%02d CPUs Total: %d\n", i, info->vm[i].cpus_total);
--
2.12.2
next prev parent reply other threads:[~2017-05-07 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 17:12 [PATCH 0/4] S390: Fine-tuning for six function implementations SF Markus Elfring
2017-05-07 17:13 ` [PATCH 1/4] s390/cache: Combine two function calls into one in show_cacheinfo() SF Markus Elfring
2017-05-07 17:14 ` [PATCH 2/4] s390/processor: Use seq_putc() in show_cpu_summary() SF Markus Elfring
2017-05-07 17:16 ` [PATCH 3/4] s390/sysinfo: Replace six seq_printf() calls by seq_puts() SF Markus Elfring
2017-05-07 17:18 ` SF Markus Elfring [this message]
2017-05-09 8:04 ` [PATCH 0/4] S390: Fine-tuning for six function implementations Vegard Nossum
2017-05-09 8:43 ` SF Markus Elfring
2017-05-09 10:30 ` [PATCH 0/4] " Ingo Molnar
2017-05-09 10:54 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04517191-f1f5-19ca-d4bc-d3d5331b4556@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=silbe@linux.vnet.ibm.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox