From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 10 Sep 2016 09:58:04 +0000 Subject: [PATCH 16/30] ACPI-processor: Use kmalloc_array() in acpi_processor_get_throttling_states() Message-Id: <09d308b2-b16f-ee86-fb15-7fd11e902018@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: Markus Elfring Date: Tue, 6 Sep 2016 19:15:02 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/acpi/processor_throttling.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c index c72e648..0a46b7f 100644 --- a/drivers/acpi/processor_throttling.c +++ b/drivers/acpi/processor_throttling.c @@ -533,9 +533,10 @@ static int acpi_processor_get_throttling_states(struct acpi_processor *pr) tss->package.count)); pr->throttling.state_count = tss->package.count; - pr->throttling.states_tss - kmalloc(sizeof(struct acpi_processor_tx_tss) * tss->package.count, - GFP_KERNEL); + pr->throttling.states_tss = kmalloc_array(tss->package.count, + sizeof(*pr-> + throttling.states_tss), + GFP_KERNEL); if (!pr->throttling.states_tss) { result = -ENOMEM; goto end; -- 2.10.0