Re: [PATCH] accel/amdxdna: Add missing include linux/slab.h

[Lizhi Hou <lizhi.hou@amd.com>]

On 2/8/25 00:05, Su Hui wrote:
> When compiling without CONFIG_IA32_EMULATION, there are some errors:
>
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘mailbox_release_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:197:2: error: implicit declaration
> of function ‘kfree’.
>    197 |  kfree(mb_msg);
>        |  ^~~~~
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘xdna_mailbox_send_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:418:11: error:implicit declaration
> of function ‘kzalloc’.
>    418 |  mb_msg = kzalloc(sizeof(*mb_msg) + pkg_size, GFP_KERNEL);
>        |           ^~~~~~~
>
> Add the missing include.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 814b16bb1953..80b4b20addd6 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -12,6 +12,7 @@
>   
>   #define CREATE_TRACE_POINTS
>   #include <trace/events/amdxdna.h>
> +#include <linux/slab.h>
Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
>   
>   #include "amdxdna_mailbox.h"
>