From: Nikolay Borisov <nborisov@suse.com>
To: YueHaibing <yuehaibing@huawei.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] btrfs: remove set but not used variable 'tree'
Date: Thu, 08 Nov 2018 06:53:58 +0000 [thread overview]
Message-ID: <0e364fdf-e5ce-0e31-aacf-d77699b5654e@suse.com> (raw)
In-Reply-To: <1541643283-109411-1-git-send-email-yuehaibing@huawei.com>
On 8.11.18 г. 4:14 ч., YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/btrfs/extent_io.c: In function 'end_extent_writepage':
> fs/btrfs/extent_io.c:2406:25: warning:
> variable 'tree' set but not used [-Wunused-but-set-variable]
>
> It not used any more after
> commit 2922040236f9 ("btrfs: Remove extent_io_ops::writepage_end_io_hook")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/extent_io.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 0f8f9c0..17a15cc 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2403,11 +2403,8 @@ static int bio_readpage_error(struct bio *failed_bio, u64 phy_offset,
> void end_extent_writepage(struct page *page, int err, u64 start, u64 end)
> {
> int uptodate = (err = 0);
> - struct extent_io_tree *tree;
> int ret = 0;
>
> - tree = &BTRFS_I(page->mapping->host)->io_tree;
> -
> btrfs_writepage_endio_finish_ordered(page, start, end, NULL, uptodate);
>
> if (!uptodate) {
>
>
>
>
next prev parent reply other threads:[~2018-11-08 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 2:14 [PATCH -next] btrfs: remove set but not used variable 'tree' YueHaibing
2018-11-08 6:53 ` Nikolay Borisov [this message]
2018-11-08 12:11 ` David Sterba
2018-12-15 6:31 ` [PATCH -next] btrfs: remove set but not used variable 'num_pages' YueHaibing
2019-01-04 15:51 ` David Sterba
2019-03-27 3:20 ` [PATCH -next] btrfs: remove set but not used variable 'fs_devices' YueHaibing
2019-03-28 14:27 ` David Sterba
2019-04-18 6:43 ` [PATCH -next] btrfs: Remove set but not used variable 'fs_info' YueHaibing
2019-04-18 6:37 ` Nikolay Borisov
2019-04-18 7:34 ` YueHaibing
2019-04-18 13:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e364fdf-e5ce-0e31-aacf-d77699b5654e@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox