From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] Input: gamecon: Delete an error message for a failed memory allocation in gc_attach()
Date: Sat, 27 Jan 2018 16:14:14 +0000 [thread overview]
Message-ID: <1097eb0c-fd33-3229-90be-417aca3795bd@users.sourceforge.net> (raw)
In-Reply-To: <e02726e3-2ee7-e690-a8ea-90a55f8fd0c2@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 16:27:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/joystick/gamecon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c
index 2ffb2e8bdc3b..f6006383d30d 100644
--- a/drivers/input/joystick/gamecon.c
+++ b/drivers/input/joystick/gamecon.c
@@ -966,10 +966,8 @@ static void gc_attach(struct parport *pp)
}
gc = kzalloc(sizeof(struct gc), GFP_KERNEL);
- if (!gc) {
- pr_err("Not enough memory\n");
+ if (!gc)
goto err_unreg_pardev;
- }
mutex_init(&gc->mutex);
gc->pd = pd;
--
2.16.1
next prev parent reply other threads:[~2018-01-27 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 16:12 [PATCH 0/2] input/joystick/gamecon: Adjustments for gc_attach() SF Markus Elfring
2018-01-27 16:14 ` SF Markus Elfring [this message]
2018-01-27 16:15 ` [PATCH 2/2] Input: gamecon: Improve a size determination in gc_attach() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097eb0c-fd33-3229-90be-417aca3795bd@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox