From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Date: Thu, 26 Apr 2018 23:29:29 +0000 Subject: Re: [PATCH 04/61] bus: simplify getting .drvdata Message-Id: <11bc8504-d32a-36fc-0a51-569fff3c4ee2@gmail.com> List-Id: References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-5-wsa+renesas@sang-engineering.com> In-Reply-To: <20180419140641.27926-5-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 04/19/2018 07:05 AM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Looks reasonable, would you want to use dev_set_drvdata() while we are it? That would bring more consistency given your proposed change. Thanks! -- -- Florian