public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning
@ 2009-10-31  5:48 Javier Martinez Canillas
  2009-11-03 18:52 ` Bing Zhao
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2009-10-31  5:48 UTC (permalink / raw)
  To: Marcel Holtmann, Bing Zhao, Rahul Tank, Julia Lawall,
	linux-bluetooth, kernel-janitors

In linux-next 20091030 I got this compile warning:

drivers/bluetooth/btmrvl_sdio.c: In function ‘btmrvl_sdio_verify_fw_download’:
drivers/bluetooth/btmrvl_sdio.c:79: warning: ‘fws1’ may be used uninitialized in this function
drivers/bluetooth/btmrvl_sdio.c:79: note: ‘fws1’ was declared here

This patch solves the issue.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
 drivers/bluetooth/btmrvl_sdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 5b33b85..41d64fd 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -76,7 +76,7 @@ static int btmrvl_sdio_get_rx_unit(struct btmrvl_sdio_card *card)
 
 static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
 {
-	u8 fws0, fws1;
+	u8 fws0, fws1 = 0;
 	int ret;
 
 	*dat = 0;
-- 
1.6.0.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning
  2009-10-31  5:48 [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning Javier Martinez Canillas
@ 2009-11-03 18:52 ` Bing Zhao
  0 siblings, 0 replies; 2+ messages in thread
From: Bing Zhao @ 2009-11-03 18:52 UTC (permalink / raw)
  To: Javier Martinez Canillas, Marcel Holtmann, Rahul Tank,
	Julia Lawall, linux-bluetooth@vger.kernel.org,
	kernel-janitors@vger.kernel.org

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1504 bytes --]

Hi Javier,

> -----Original Message-----
> From: Javier Martinez Canillas [mailto:martinez.javier@gmail.com]
> Sent: Friday, October 30, 2009 10:49 PM
> To: Marcel Holtmann; Bing Zhao; Rahul Tank; Julia Lawall; linux-bluetooth@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning
> 
> In linux-next 20091030 I got this compile warning:
> 
> drivers/bluetooth/btmrvl_sdio.c: In function ‘btmrvl_sdio_verify_fw_download’:
> drivers/bluetooth/btmrvl_sdio.c:79: warning: ‘fws1’ may be used uninitialized in this function
> drivers/bluetooth/btmrvl_sdio.c:79: note: ‘fws1’ was declared here
> 
> This patch solves the issue.

Your patch is valid.

Thanks,

Bing

> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
>  drivers/bluetooth/btmrvl_sdio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
> index 5b33b85..41d64fd 100644
> --- a/drivers/bluetooth/btmrvl_sdio.c
> +++ b/drivers/bluetooth/btmrvl_sdio.c
> @@ -76,7 +76,7 @@ static int btmrvl_sdio_get_rx_unit(struct btmrvl_sdio_card *card)
> 
>  static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
>  {
> -	u8 fws0, fws1;
> +	u8 fws0, fws1 = 0;
>  	int ret;
> 
>  	*dat = 0;
> --
> 1.6.0.4
> 
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¤z¹Þ—øÚž+h®ÏâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-03 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-31  5:48 [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning Javier Martinez Canillas
2009-11-03 18:52 ` Bing Zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox