drivers/gpu/drm/radeon/radeon_fence.c: move a dereference below

Darren Jenkins
2009-12-24T12:52:00Z

If a NULL value is possible, the dereference should only occur after the
NULL test.

Coverity CID: 13334

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
diff --git a/drivers/gpu/drm/radeon/radeon_fence.c
b/drivers/gpu/drm/radeon/radeon_fence.c
index cb4cd97..f4f5942 100644
--- a/drivers/gpu/drm/radeon/radeon_fence.c
+++ b/drivers/gpu/drm/radeon/radeon_fence.c
@@ -140,14 +140,14 @@ int radeon_fence_create(struct radeon_device
*rdev, struct radeon_fence **fence)

bool radeon_fence_signaled(struct radeon_fence *fence)
{
- struct radeon_device *rdev = fence->rdev;
unsigned long irq_flags;
bool signaled = false;

- if (rdev->gpu_lockup) {
+ if (fence = NULL) {
return true;
}
- if (fence = NULL) {
+
+ if (fence->rdev->gpu_lockup) {
return true;
}
write_lock_irqsave(&fence->rdev->fence_drv.lock, irq_flags);