From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] arch/powerpc/platforms/pseries/ras.c - cleanup
Date: Tue, 09 Mar 2010 10:44:11 +0000 [thread overview]
Message-ID: <1268131451.16616.1.camel@thorin> (raw)
In-Reply-To: <hn3osd$4in$1@dough.gmane.org>
On Mon, 2010-03-08 at 22:06 +0100, Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against arch/powerpc/platforms/pseries/ras.c.
>
> No need to memset (.., 0, ...) a buffer that is complety filled by a memcpy
> the line after.
>
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c
> b/arch/powerpc/platforms/pseries/ras.c
> index 2b548af..7a401ed 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -276,7 +276,6 @@ static struct rtas_error_log *fwnmi_get_errinfo(struct
> pt_regs *regs)
> (errdata >= rtas.base && errdata < rtas.base + rtas.size - 16)) {
> savep = __va(errdata);
> regs->gpr[3] = savep[0]; /* restore original r3 */
> - memset(mce_data_buf, 0, RTAS_ERROR_LOG_MAX);
> memcpy(mce_data_buf, (char *)(savep + 1), RTAS_ERROR_LOG_MAX);
While you are at it, this ^^^^^^^^ type cast is superfluous too.
> errhdr = (struct rtas_error_log *)mce_data_buf;
> } else {
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
prev parent reply other threads:[~2010-03-09 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:06 [patch] arch/powerpc/platforms/pseries/ras.c - cleanup Christophe Jaillet
2010-03-08 21:36 ` Julia Lawall
2010-03-09 6:14 ` Christophe Jaillet
2010-03-09 17:21 ` Julia Lawall
2010-03-09 10:44 ` Bernd Petrovitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268131451.16616.1.camel@thorin \
--to=bernd@petrovitsch.priv.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox