From: Zhang Rui <rui.zhang@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "casteyde.christian@free.fr" <casteyde.christian@free.fr>,
Andrew Morton <akpm@linux-foundation.org>,
"Brown, Len" <len.brown@intel.com>,
Matthew Garrett <mjg@redhat.com>, Frans Pop <elendil@planet.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] thermal: make lockdep happy
Date: Thu, 01 Apr 2010 01:44:50 +0000 [thread overview]
Message-ID: <1270086290.24064.4466.camel@rzhang1-desktop> (raw)
In-Reply-To: <20100331170916.GA13784@bicker>
On Thu, 2010-04-01 at 01:09 +0800, Dan Carpenter wrote:
> Hi Christian,
>
> Can you test this patch?
>
> I wrote this to address bugzilla bug:
> https://bugzilla.kernel.org/show_bug.cgi?id\x15504
> BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c
>
> We now have to call sysfs_attr_init() for dynamically allocated sysfs
> attributes or lockdep complains.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 5066de5..d4fec47 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
> goto release_idr;
>
> sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
> + sysfs_attr_init(&dev->attr.attr);
> dev->attr.attr.name = dev->attr_name;
> dev->attr.attr.mode = 0444;
> dev->attr.show = thermal_cooling_device_trip_point_show;
prev parent reply other threads:[~2010-04-01 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 17:09 [patch] thermal: make lockdep happy Dan Carpenter
2010-03-31 20:17 ` Christian Casteyde
2010-04-01 1:44 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270086290.24064.4466.camel@rzhang1-desktop \
--to=rui.zhang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=casteyde.christian@free.fr \
--cc=elendil@planet.nl \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).