* [patch] thermal: make lockdep happy
@ 2010-03-31 17:09 Dan Carpenter
2010-03-31 20:17 ` Christian Casteyde
2010-04-01 1:44 ` Zhang Rui
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-31 17:09 UTC (permalink / raw)
To: Zhang Rui, casteyde.christian
Cc: Andrew Morton, Len Brown, Matthew Garrett, Frans Pop,
linux-kernel, kernel-janitors
Hi Christian,
Can you test this patch?
I wrote this to address bugzilla bug:
https://bugzilla.kernel.org/show_bug.cgi?id\x15504
BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c
We now have to call sysfs_attr_init() for dynamically allocated sysfs
attributes or lockdep complains.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 5066de5..d4fec47 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
goto release_idr;
sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
+ sysfs_attr_init(&dev->attr.attr);
dev->attr.attr.name = dev->attr_name;
dev->attr.attr.mode = 0444;
dev->attr.show = thermal_cooling_device_trip_point_show;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] thermal: make lockdep happy
2010-03-31 17:09 [patch] thermal: make lockdep happy Dan Carpenter
@ 2010-03-31 20:17 ` Christian Casteyde
2010-04-01 1:44 ` Zhang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Christian Casteyde @ 2010-03-31 20:17 UTC (permalink / raw)
To: Dan Carpenter, Zhang Rui, Andrew Morton, Len Brown,
Matthew Garrett, Frans Pop, linux-kernel, kernel-janitors
Seems to fix it, at least when applied on -rc3.
I'm updating the bugzilla entry.
Thanks.
Le mercredi 31 mars 2010, Dan Carpenter a écrit :
> Hi Christian,
>
> Can you test this patch?
>
> I wrote this to address bugzilla bug:
> https://bugzilla.kernel.org/show_bug.cgi?id\x15504
> BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c
>
> We now have to call sysfs_attr_init() for dynamically allocated sysfs
> attributes or lockdep complains.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 5066de5..d4fec47 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct
> thermal_zone_device *tz, goto release_idr;
>
> sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
> + sysfs_attr_init(&dev->attr.attr);
> dev->attr.attr.name = dev->attr_name;
> dev->attr.attr.mode = 0444;
> dev->attr.show = thermal_cooling_device_trip_point_show;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] thermal: make lockdep happy
2010-03-31 17:09 [patch] thermal: make lockdep happy Dan Carpenter
2010-03-31 20:17 ` Christian Casteyde
@ 2010-04-01 1:44 ` Zhang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Zhang Rui @ 2010-04-01 1:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: casteyde.christian@free.fr, Andrew Morton, Brown, Len,
Matthew Garrett, Frans Pop, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Thu, 2010-04-01 at 01:09 +0800, Dan Carpenter wrote:
> Hi Christian,
>
> Can you test this patch?
>
> I wrote this to address bugzilla bug:
> https://bugzilla.kernel.org/show_bug.cgi?id\x15504
> BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c
>
> We now have to call sysfs_attr_init() for dynamically allocated sysfs
> attributes or lockdep complains.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 5066de5..d4fec47 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
> goto release_idr;
>
> sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
> + sysfs_attr_init(&dev->attr.attr);
> dev->attr.attr.name = dev->attr_name;
> dev->attr.attr.mode = 0444;
> dev->attr.show = thermal_cooling_device_trip_point_show;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-01 1:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-31 17:09 [patch] thermal: make lockdep happy Dan Carpenter
2010-03-31 20:17 ` Christian Casteyde
2010-04-01 1:44 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).