public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Palix <npalix@diku.dk>
To: Randy Dunlap <rdunlap@xenotime.net>,
	Roland Dreier <rdreier@cisco.com>, Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Michal Marek <mmarek@suse.cz>, Sam Ravnborg <sam@ravnborg.org>,
	Julia Lawall <julia@diku.dk>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	cocci@diku.dk, Wolfram Sang <w.sang@pengutronix.de>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
	Nicolas Palix <npalix@diku.dk>
Subject: [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci
Date: Mon, 10 May 2010 16:24:26 +0000	[thread overview]
Message-ID: <1273508667-5152-4-git-send-email-npalix@diku.dk> (raw)
In-Reply-To: <1273508667-5152-1-git-send-email-npalix@diku.dk>

This semantic patch replaces a pair of calls to kmalloc and memset
by a single call to kzalloc.

It only looks for simple cases to avoid false positives.

Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
 scripts/coccinelle/kzalloc-simple.cocci |   83 +++++++++++++++++++++++++++++++
 1 files changed, 83 insertions(+), 0 deletions(-)
 create mode 100644 scripts/coccinelle/kzalloc-simple.cocci

diff --git a/scripts/coccinelle/kzalloc-simple.cocci b/scripts/coccinelle/kzalloc-simple.cocci
new file mode 100644
index 0000000..b099fea
--- /dev/null
+++ b/scripts/coccinelle/kzalloc-simple.cocci
@@ -0,0 +1,83 @@
+///
+/// kzalloc should be used rather than kmalloc followed by memset 0
+///
+// Confidence: High
+// Copyright: (C) 2009-2010 Julia Lawall, Nicolas Palix, DIKU.  GPLv2.
+// Copyright: (C) 2009-2010 Gilles Muller, INRIA/LiP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/rules/kzalloc.html
+// Options: -no_includes -include_headers
+//
+// Keywords: kmalloc, kzalloc
+// Version min: < 12 kmalloc
+// Version min:   14 kzalloc
+// Version max: *
+//
+
+virtual context
+virtual patch
+virtual org
+virtual report
+
+//----------------------------------------------------------
+//  For context mode
+//----------------------------------------------------------
+
+@depends on context@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+@@
+
+* x = (T)kmalloc(E1,E2);
+  if ((x=NULL) || ...) S
+* memset((T2)x,0,E1);
+
+//----------------------------------------------------------
+//  For patch mode
+//----------------------------------------------------------
+
+@depends on patch@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+@@
+
+- x = (T)kmalloc(E1,E2);
++ x = kzalloc(E1,E2);
+  if ((x=NULL) || ...) S
+- memset((T2)x,0,E1);
+
+//----------------------------------------------------------
+//  For org mode
+//----------------------------------------------------------
+
+@r depends on org || report@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+position p;
+@@
+
+ x = (T)kmalloc@p(E1,E2);
+ if ((x=NULL) || ...) S
+ memset((T2)x,0,E1);
+
+@script:python depends on org@
+p << r.p;
+x << r.x;
+@@
+
+msg="%s" % (x)
+msg_safe=msg.replace("[","@(").replace("]",")")
+coccilib.org.print_todo(p[0], msg_safe)
+
+@script:python depends on report@
+p << r.p;
+x << r.x;
+@@
+
+msg="WARNING: kzalloc should be used for %s, instead of kmalloc/memset" % (x)
+coccilib.report.print_report(p[0], msg_safe)
-- 
1.7.0.4


  parent reply	other threads:[~2010-05-10 16:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 16:19 [PATCH 0/4] Add a Coccinelle front-end script Nicolas Palix
2010-05-10 16:24 ` Nicolas Palix
2010-05-10 16:24   ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-05-12  6:42     ` Américo Wang
2010-05-28  7:04       ` Joerg Roedel
2010-06-03  9:50     ` Michal Marek
2010-06-03 10:23     ` Sam Ravnborg
2010-06-04  9:56       ` Nicolas Palix
2010-06-04 10:38         ` Sam Ravnborg
2010-05-10 16:24   ` [PATCH 2/4] Add scripts/coccinelle/drop_kmalloc_cast.cocci Nicolas Palix
2010-05-10 16:24   ` Nicolas Palix [this message]
2010-06-03  9:51     ` [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Michal Marek
2010-06-03 10:11       ` Nicolas Palix
2010-05-10 16:24   ` [PATCH 4/4] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-05-10 16:52     ` Pekka Enberg
2010-05-27 11:48       ` Nicolas Palix
2010-05-11  2:14   ` [PATCH 0/4] Add a Coccinelle front-end script Andy Isaacson
2010-05-17  9:31     ` Wolfram Sang
2010-05-28  7:09   ` Joerg Roedel
2010-05-28  7:25     ` Wolfram Sang
2010-05-28  7:31       ` Julia Lawall
2010-05-28  7:39         ` walter harms
2010-05-28  9:15         ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2010-05-10 16:19 [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Nicolas Palix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273508667-5152-4-git-send-email-npalix@diku.dk \
    --to=npalix@diku.dk \
    --cc=Gilles.Muller@lip6.fr \
    --cc=akpm@linux-foundation.org \
    --cc=cocci@diku.dk \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rdreier@cisco.com \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox